149102 - Kill TypicalInput/OutputStream

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Alec Flett]

we have this old nsFileSpec-based input stream that you create with
NS_NewTypicalOutputFileStream - we could eliminate alot of dead code.

2 patches forthcoming - one to eliminate consumers, and one to remove it from xpcom.

Comment 1

[Alec Flett]

Attachment: fix consumers, other cleanup

There is some other minor cleanup in this patch:
1) using the PRBool() operator in BoolRegistryEntry in nsWindowsHooks.cpp - for
some reason we were leaping through the void*() operator, and this fixes that,
making the code much easier to read.
2) using the directory service to find the temporary directory for plugin
streams, rather than having a platform-specific #ifdef

I'd love an r=dougt, sr=jaggernaut on this, but I'm also going to get an r=av
on the plugin stuff.

Comment 2

[av (gone)]

Adding plugins engineers for feedback on plugin code changes. Thank, Alec, for
letting me know.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 86280 [details] [diff] [review]
fix consumers, other cleanup

alec, optionally instead of 

nsCOMPtr<nsILocalFile> path = do_CreateInstance(NS_LOCAL_FILE_CONTRACTID, &rv);

You could call NS_NewLocalFile().  See nsILocalFile (soon to be moved to
nsXPCOM.h)

nit: You spaced all the other correctly.  The paran and semicolon should be
spaced out.

+    prefs->mHandleHTTP   = BoolRegistryEntry( "isHandlingHTTP");
+    prefs->mHandleHTTPS  = BoolRegistryEntry( "isHandlingHTTPS"  );

r=dougt

Comment 4

[av (gone)]

Are we getting rid of nsFileSpec alltogether? Then we have more consumers in the
plugin code, I think.

Comment 5

[jag (Peter Annema)]

That's a different bug.

Comment 6

[Alec Flett]

av/peterl/serge - so can I get an r= from one of you on the plugin part of this
patch? I just want to make sure I'm doing the right thing here.

Comment 7

[av (gone)]

Comment on attachment 86280 [details] [diff] [review]
fix consumers, other cleanup

fine with me, r=av

Comment 8

[jag (Peter Annema)]

Comment on attachment 86280 [details] [diff] [review]
fix consumers, other cleanup

sr=jag

Comment 9

[Alec Flett]

mozilla 1.1alpha already passed, just moving out to 1.1beta

Comment 10

[Alec Flett]

Attachment: stop exporting NS_NewTypical*

ok, no need to export these functions any more - allows compiler/linker to
possibly optimize them away...

can I get another review here? this one is easy...dougt? jag?

Comment 11

[Alec Flett]

oh that also kills some nsOutputConsoleStream which is only used in FilesTest,
which is only used to test the outdated nsFileSpec - I've been slowly
dismantling FilesTest as I've hacked apart nsFileSpec, I don't think anyone even
runs it anymore. So anyway, I'm taking xpcom/tests/FileTest.cpp out of the build
as well.

Comment 12

[jag (Peter Annema)]

Comment on attachment 87545 [details] [diff] [review]
stop exporting NS_NewTypical*

sr=jag

Comment 13

[Doug Turner (:dougt)]

Comment on attachment 87545 [details] [diff] [review]
stop exporting NS_NewTypical*

r=dougt.  good stuff!

Comment 14

[Alec Flett]

done and done.