1491024 - Rename userScripts manifest properties to be consistent with the manifest property name conventions

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The userScripts API allows an extension to specify an extension url to be used as the script which can provide custom API methods to the isolated userScript sandboxes, this manifest property is currently named `userScripts.apiScript`.

We should renamed it to `user_scripts.api_script`, so that it follows the same name conventions used by the rest of the manifest properties.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1491024 - Rename userScripts manifest property to follow manifest property name conventions. r?mixedpuppy!

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9008776 [details]
Bug 1491024 - Rename userScripts manifest property to follow manifest property name conventions. r?mixedpuppy!

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1cc448b5137
Rename userScripts manifest property to follow manifest property name conventions. r=mixedpuppy

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88ba6771fdc0
Backed out changeset f1cc448b5137 for failures on test_ext_userScripts. CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1f6617eece2
Rename userScripts manifest property to follow manifest property name conventions. r=mixedpuppy

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a1f6617eece2

Comment 7

[Victor Carciu]

Cab you please add some STRs to this issue(and a test webext if possible) or mark it as "qe-verify-" ?

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Victor Carciu from comment #7)
> Cab you please add some STRs to this issue(and a test webext if possible) or
> mark it as "qe-verify-" ?

I'm marking this qe-verify-, as it is tested in the automated tests (and it has also been verified as a side-effect of the QA verification we did for Bug 1437864).