Closed Bug 1491035 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12989 - Insert an error message block when parsing was stopped after an error

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12989 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12989
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:
>  Insert an error message block when parsing was stopped after an error
>  
>  The <parsererror> element was not being added to the parsed document in
>  certain cases involving attribute parsing. For example, if an undeclared
>  namespace prefix was used in the document, then parsing would stop, but
>  a <parsererror> element would not be inserted into the document to
>  indicate that a parsing error occurred.
>  
>  When XMLDocumentParser::StopParsing() is called to stop parsing, call
>  InsertErrorMessageBlock() to insert the <parsererror> element if an
>  error occurred.
>  
>  Based on https://codereview.chromium.org/771493002/ by dtrebbien@gmail.com
>  
>  Bug: 295809
>  Change-Id: Ic67a3ab885fae4b01ca92f6d927b3f523f7423ed
>  Reviewed-on: https://chromium-review.googlesource.com/1224791
>  WPT-Export-Revision: 29df271dce4a48780eaceffeb4c2c908acb04d06
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 1 tests and 17 subtests
OK     : 1
PASS   : 17
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c0ba663cd4
[wpt PR 12989] - Insert an error message block when parsing was stopped after an error, a=testonly
https://hg.mozilla.org/mozilla-central/rev/f8c0ba663cd4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.