Closed Bug 1491042 Opened 6 years ago Closed 6 years ago

Selected tab has almost no padding-left/right in preferences Certificate Manager

Categories

(Toolkit :: Themes, defect, P1)

Product:
Toolkit
Component:
Themes
Platform:
All
Windows
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- verified
firefox64 --- verified

People

(Reporter: Paenglab, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

screenshot.png
9.13 KB, image/png
Details
patch
2.96 KB, patch
Paenglab
: review+
pascalc
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image screenshot.png — 
See screenshot.

STR:
1. Go to Preferences, Privacy & Security.
2. Scroll to the bottom of that page and click the 'View Certificates...' button.
3. In the modal dialog that pops up, notice the missing padding of the selected tab.
Attached patch patch — — Splinter Review 
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

        Attachment #9010190 -
        Flags: review?(richard.marti)

    
  
Priority: -- → P1

    
    

    
  
Comment on attachment 9010190 [details] [diff] [review]
patch

Thanks!

        Attachment #9010190 -
        Flags: review?(richard.marti) → review+

    
    

    
  
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3eb47f81993
Clean up padding, margin, and border overrides for in-content tabs after tabbox.css changes. r=Paenglab

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/a3eb47f81993
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox64:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

    
  
Flags: qe-verify+

    
    

    
  
Comment on attachment 9010190 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1446168
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward CSS cleanup
[String changes made/needed]: /

        Attachment #9010190 -
        Flags: approval-mozilla-beta?

    
    

    
  
Comment on attachment 9010190 [details] [diff] [review]
patch

CSS fix for a P1 regression, patch on nightly for a week, uplift approved for 63 beta 10, thanks.

        Attachment #9010190 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
    

    
  
I successfully reproduced the issue on Firefox Nightly 64.0a1 (2018-09-13) under Windows 10 (x64) using STR from Comment 0.

The issue is verified fixed on latest Nightly 64.0a1 (2018-09-25) under Windows 10 (x64).

I'll be verifying on Beta too, as soon as the build with the fix will be available.

          status-firefox64:
          fixed → verified

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
The issue is verified fixed on Firefox Beta 63.0b10 under Windows 10 (x64).

          status-firefox63:
          fixed → verified
Flags: qe-verify+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: