1491042 - Selected tab has almost no padding-left/right in preferences Certificate Manager

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Richard Marti (:Paenglab)]

Attachment: screenshot.png

See screenshot.

STR:
1. Go to Preferences, Privacy & Security.
2. Scroll to the bottom of that page and click the 'View Certificates...' button.
3. In the modal dialog that pops up, notice the missing padding of the selected tab.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9010190 [details] [diff] [review]
patch

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3eb47f81993
Clean up padding, margin, and border overrides for in-content tabs after tabbox.css changes. r=Paenglab

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a3eb47f81993

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9010190 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1446168
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward CSS cleanup
[String changes made/needed]: /

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9010190 [details] [diff] [review]
patch

CSS fix for a P1 regression, patch on nightly for a week, uplift approved for 63 beta 10, thanks.

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I successfully reproduced the issue on Firefox Nightly 64.0a1 (2018-09-13) under Windows 10 (x64) using STR from Comment 0.

The issue is verified fixed on latest Nightly 64.0a1 (2018-09-25) under Windows 10 (x64).

I'll be verifying on Beta too, as soon as the build with the fix will be available.

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef7e76233d53

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The issue is verified fixed on Firefox Beta 63.0b10 under Windows 10 (x64).