149106 - [FIX]text-decoration does not work on font with color

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Paul Steckler]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 
1.0.3705)
BuildID:    2002052306

A table contains multiple rows (TRs), each of which 
contains a FONT element.  Two of the FONT elements have a STYLE
attribute with text-decoration:underline.  The actual
underline is rendered for the text in only one of the elements.

In IE6, the text in both elements is rendered with an 
underline.

Reproducible: Always
Steps to Reproduce:
1. Look at http://www.ccs.neu.edu/tmp/moz-ul-bug.html
2.
3.

Actual Results:  Saw underline for "Item two" only

Expected Results:  Expected underline for "Item two" and "Item three"

Comment 1

[Chris Petersen]

Confirming issue in the 2002-06-05-05 1.0.0 OS X build.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: fix

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 121861 [details] [diff] [review]
fix

David, would you review?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: More extensive testcase

Comment 6

[Boris Zbarsky [:bzbarsky]]

Resummarizing to the actual problem.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 121861 [details] [diff] [review]
fix

Isn't what you really want to do the equivalent of "|=" ?

Also, it might be that the NS_STYLE_TEXT_DECORATION_OVERRIDE_ALL is ignored in
standards mode.

(Also, the indentation of the ColorName line is one character too small.)

Comment 8

[Boris Zbarsky [:bzbarsky]]

You're right, it's ignored in standards mode.

I'd sorta like a |=, yes.  But see the code in
nsStyleContext::ApplyStyleFixups... The difference between |= and that patch is
that a <font> with an overline on it would not override the underline color of
the surrounding anchor... do we care about that case?  If so, we need a way of
doing bit-values for nsCSSValue...

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

How about:
  foo.SetIntValue(NS_STYLE_... | foo.GetIntValue())

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Better fix

Comment 11

[Boris Zbarsky [:bzbarsky]]

Checked in.