Closed Bug 1491066 Opened Last year Closed Last year
.ua _widget .enabled breaks ::cue
46 bytes, text/x-phabricator-request
|Details | Review|
See https://bugzilla.mozilla.org/show_bug.cgi?id=1490793#c7 for a test-case.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
There is already a patch in bug 1484048. https://phabricator.services.mozilla.com/D3667 . I can land that patch w/ from this bug.
With UA Widget, the videocontrols container is created lazily. It won't be a problem for WebVTT.processCues() in vtt.jsm, so TextTrackManager::UpdateCueDisplay() should not early return there, but pass nullptr to it.
Comment on attachment 9008914 [details] Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu Alastor Wu [:alwu] has approved the revision.
Attachment #9008914 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b88bbab404c6 Allow TextTrackManager to pass cue without videocontrols r=alwu
I have to say, the whole thing is a bit flicky for me, sometimes it shows up, sometimes it doesn't and it only shows up with a reload. But that's a separate bug I think...
You need to log in before you can comment on or make changes to this bug.