1491066 - dom.ua_widget.enabled breaks ::cue

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1490793#c7 for a test-case.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

There is already a patch in bug 1484048. https://phabricator.services.mozilla.com/D3667 .

I can land that patch w/ from this bug.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu

With UA Widget, the videocontrols container is created lazily.
It won't be a problem for WebVTT.processCues() in vtt.jsm, so
TextTrackManager::UpdateCueDisplay() should not early return there, but pass
nullptr to it.

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 9008914 [details]
Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu

Alastor Wu [:alwu] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b88bbab404c6
Allow TextTrackManager to pass cue without videocontrols r=alwu

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I have to say, the whole thing is a bit flicky for me, sometimes it shows up, sometimes it doesn't and it only shows up with a reload. But that's a separate bug I think...

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b88bbab404c6