1491108 - arrow icon too large in bookmark dialog on macOS

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

Since bug 1487765 the arrow in the folder dropdown of the bookmark dialog is too large on macOS.

13:54.74 INFO: Narrowed inbound regression window from [906330f7, 140cc361] (3 builds) to [906330f7, 598ede9c] (2 builds) (~1 steps left)
13:54.74 INFO: No more inbound revisions, bisection finished.
13:54.74 INFO: Last good revision: 906330f7adc8cf71d9a39c1ff0fdd592ae7a9d28
13:54.74 INFO: First bad revision: 598ede9c5a5de8fcf23754e07a7c8079273013f4
13:54.74 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=906330f7adc8cf71d9a39c1ff0fdd592ae7a9d28&tochange=598ede9c5a5de8fcf23754e07a7c8079273013f4

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 9009031 [details] [diff] [review]
patch

Review of attachment 9009031 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: browser/themes/osx/browser.css
@@ +486,5 @@
>  #editBMPanel_folderMenuList > .menulist-dropmarker {
>    -moz-appearance: none;
>    display: -moz-box;
> +  -moz-box-align: center;
> +  -moz-box-pack: center;

-moz-box-pack: center; doesn't seem to have any effect.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e1392efab8f
Fix #editBMPanel_folderMenuList dropmarker styling after dropmarker.css changes. r=ntim

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7e1392efab8f