1491248 - Display one-off search buttons correctly in the UrlbarView panel

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Dão Gottwald [:dao]]

https://hg.mozilla.org/mozilla-central/annotate/tip/browser/base/content/browser.xul#l227

There are two options here. We can re-implement this as HTML inside urlbarView-body-inner, or we can just copy the XUL implementation as a sibling to urlbarView-body-outer.

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Dão Gottwald [::dao] from comment #0)
> https://hg.mozilla.org/mozilla-central/annotate/tip/browser/base/content/
> browser.xul#l227
> 
> There are two options here. We can re-implement this as HTML inside
> urlbarView-body-inner, or we can just copy the XUL implementation as a
> sibling to urlbarView-body-outer.

Which option are you leaning towards, and what's your timeline here? And would porting the existing search-one-offs to a Custom Element (bug 1493536) somehow interact with the decision? I'm guessing we'll want to ultimately share the same impl between the search popup and URL bar (either a brand new HTML widget, ported XUL CE, or ported XUL CE modified to use HTML).

Comment 2

[Mike de Boer [:mikedeboer]]

I'm quite a strong defender of moving all the things to HTML here, because this is important for the extensibility of the URLBarView component; future A/B test experiment _need_ to be able to swap out the one-off buttons using the same mechanism. If we force experiment authors to _again_ be aware of legacy technology - XUL - and mix it with HTML for the results, we're missing the point entirely.

If there's some kind of impediment that blocks an HTML implementation for QuantumBar, let's try to discuss and resolve it early.

Comment 3

[Dão Gottwald [:dao]]

As mentioned in bug 1491247, I wasn't suggesting that we keep XUL but that using what we have might be a reasonable first step.

(In reply to Brian Grinstead [:bgrins] from comment #1)
> (In reply to Dão Gottwald [::dao] from comment #0)
> > https://hg.mozilla.org/mozilla-central/annotate/tip/browser/base/content/
> > browser.xul#l227
> > 
> > There are two options here. We can re-implement this as HTML inside
> > urlbarView-body-inner, or we can just copy the XUL implementation as a
> > sibling to urlbarView-body-outer.
> 
> Which option are you leaning towards, and what's your timeline here? And
> would porting the existing search-one-offs to a Custom Element (bug 1493536)
> somehow interact with the decision?

A custom element is likely overkill here. We just need a class that takes a container and does stuff with it, and then we can use that in two places.

I have no timeline but this is needed for reaching parity with the old urlbar, so we'll look into this soon.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1491248 - Display one-off search buttons correctly in the UrlbarView panel. r=Standard8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b74ecf5173c2
Display one-off search buttons correctly in the UrlbarView panel. r=Standard8

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b74ecf5173c2