1491281 - Make id and title props optional for Tab components in Inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Razvan Caliman [:rcaliman]]

When registering a new sidebar tab in the inspector, there's needless duplication of the tab id and title which are passed as props to the React component:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#917-920,945-948,966-969

This could be solved in Tabbar.js `renderTab()` by inferring the id and title props to be the same as the tab's id and title attributes. 
https://searchfox.org/mozilla-central/source/devtools/client/shared/components/tabs/TabBar.js#308-319

In case explicit props are defined, they should be used instead.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1491281 - Use tab id and title as fallbacks for panel props in Inspector sidebar tabs; r=gl

Avoid needless duplication if tab id and title as props when creating Inspector sidebar tab components.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91599d4283b5
Use tab id and title as fallbacks for panel props in Inspector sidebar tabs; r=gl

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/91599d4283b5

Comment 4

[Julian Descottes [:jdescottes]]

This patch breaks the inspector if you use the dev version of react (`ac_add_options --enable-debug-js-modules` in mozconfig). 

  JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/components/tabs/TabBar.js, line 321: TypeError: "props" is read-only

Any idea how we could fix this?

Comment 5

[Razvan Caliman [:rcaliman]]

Reverted this change with the fix for Bug 1503192