_setPositionalAttributes accesses selectedItem too often

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

({perf})

Trunk
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
The selectedItem getter is kind of expensive, we should only access it once in _setPositionalAttributes.
(Assignee)

Comment 1

7 months ago
Posted patch patchSplinter Review
Attachment #9009084 - Flags: review?(florian)
Attachment #9009084 - Flags: review?(florian) → review+

Comment 2

7 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cae5a527a4b
Access selectedItem only once in _setPositionalAttributes. r=florian

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1cae5a527a4b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
(Assignee)

Updated

7 months ago
Blocks: 1491784
(Assignee)

Updated

7 months ago
Blocks: 1491786
You need to log in before you can comment on or make changes to this bug.