Closed
Bug 1491313
Opened 6 years ago
Closed 6 years ago
Add some instrumentation to figure out why ClearDocumentDependentSlots crashes
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See bug 1405521 comment 1. It would be good to figure out which exact thing there is failing. I'm going to try adding a bunch of MOZ_CRASH annotations with a description string that points to bug 1488480 and bug 1405521 and then maybe we'll have a better idea of which of those cases is being hit....
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•6 years ago
|
||
We need the isDOMClass() checks in the Compartment code to pass tests, because some of the jsapi tests explicitly test those failure codepaths. But not with DOM objects, which is what we're interested in here.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9009643 [details] Bug 1491313. Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8,jandem Andrew McCreight [:mccr8] has approved the revision.
Attachment #9009643 -
Flags: review+
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9009643 [details] Bug 1491313. Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8,jandem Jan de Mooij [:jandem] has approved the revision.
Attachment #9009643 -
Flags: review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9205d38f866c Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=jandem,mccr8
|
||
Comment 5•6 years ago
|
||
Backed out changeset 9205d38f866c (bug 1491313) for causing crashtests to fail. CLOSED TREE Log: INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/reftest/tests/layout/base/crashtests/817219.html [task 2018-09-17T19:54:22.521Z] 19:54:22 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/base/crashtests/817219.html | 1724 / 3606 (47%) [task 2018-09-17T19:54:22.678Z] 19:54:22 INFO - JavaScript error: file:///builds/worker/workspace/build/tests/reftest/tests/layout/base/crashtests/817219-iframe.html, line 26: too much recursion [task 2018-09-17T19:54:22.694Z] 19:54:22 INFO - AddressSanitizer:DEADLYSIGNAL [task 2018-09-17T19:54:22.694Z] 19:54:22 INFO - ================================================================= [task 2018-09-17T19:54:22.696Z] 19:54:22 ERROR - ==1128==ERROR: AddressSanitizer: ILL on unknown address 0x7fc63dbf7fe9 (pc 0x7fc63dbf7fe9 bp 0x7ffeb42cb690 sp 0x7ffeb42cb3c0 T0) [task 2018-09-17T19:54:24.034Z] 19:54:24 INFO - #0 0x7fc63dbf7fe8 in AnnotateMozCrashReason /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:40:19 [task 2018-09-17T19:54:24.035Z] 19:54:24 INFO - #1 0x7fc63dbf7fe8 in DoGetOrCreateDOMReflector<mozilla::dom::Event, mozilla::dom::binding_detail::eWrapIntoContextCompartment> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:1087 [task 2018-09-17T19:54:24.038Z] 19:54:24 INFO - #2 0x7fc63dbf7fe8 in GetOrCreateDOMReflector<mozilla::dom::Event> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:1168 [task 2018-09-17T19:54:24.040Z] 19:54:24 INFO - #3 0x7fc63dbf7fe8 in GetOrCreate /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:1819 [task 2018-09-17T19:54:24.042Z] 19:54:24 INFO - #4 0x7fc63dbf7fe8 in GetOrCreateDOMReflector<mozilla::dom::Event> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:1829 [task 2018-09-17T19:54:24.045Z] 19:54:24 INFO - #5 0x7fc63dbf7fe8 in mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/EventListenerBinding.cpp:29 [task 2018-09-17T19:54:24.054Z] 19:54:24 INFO - #6 0x7fc63ebc23cf in HandleEvent<mozilla::dom::EventTarget *> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/EventListenerBinding.h:66:12 [task 2018-09-17T19:54:24.055Z] 19:54:24 INFO - #7 0x7fc63ebc23cf in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /builds/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1108 [task 2018-09-17T19:54:24.056Z] 19:54:24 INFO - #8 0x7fc63ebc4070 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /builds/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1342:20 [task 2018-09-17T19:54:24.056Z] 19:54:24 INFO - #9 0x7fc63ebade28 in HandleEvent /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/EventListenerManager.h:390:5 [task 2018-09-17T19:54:24.057Z] 19:54:24 INFO - #10 0x7fc63ebade28 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:420 [task 2018-09-17T19:54:24.057Z] 19:54:24 INFO - #11 0x7fc63ebabfd1 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:567:12 [task 2018-09-17T19:54:24.058Z] 19:54:24 INFO - #12 0x7fc63ebb1b1c in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:1112:9 [task 2018-09-17T19:54:24.059Z] 19:54:24 INFO - #13 0x7fc63ebb4328 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp [task 2018-09-17T19:54:24.075Z] 19:54:24 INFO - #14 0x7fc63bdb9ea4 in nsIDocument::DispatchPageTransition(mozilla::dom::EventTarget*, nsTSubstring<char16_t> const&, bool, bool) /builds/worker/workspace/build/src/dom/base/nsDocument.cpp:8517:3 [task 2018-09-17T19:54:24.077Z] 19:54:24 INFO - #15 0x7fc63bdbaada in nsIDocument::OnPageShow(bool, mozilla::dom::EventTarget*, bool) /builds/worker/workspace/build/src/dom/base/nsDocument.cpp:8584:5 [task 2018-09-17T19:54:24.094Z] 19:54:24 INFO - #16 0x7fc640fa507f in nsDocumentViewer::LoadComplete(nsresult) /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:1192:20 [task 2018-09-17T19:54:24.095Z] 19:54:24 INFO - #17 0x7fc643ac9cfd in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:7088:21 [task 2018-09-17T19:54:24.095Z] 19:54:24 INFO - #18 0x7fc643ac6059 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:6881:7 [task 2018-09-17T19:54:24.096Z] 19:54:24 INFO - #19 0x7fc643acd66f in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp [task 2018-09-17T19:54:24.099Z] 19:54:24 INFO - #20 0x7fc63a950a04 in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:1309:3 [task 2018-09-17T19:54:24.100Z] 19:54:24 INFO - #21 0x7fc63a94fa87 in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:852:14 [task 2018-09-17T19:54:24.101Z] 19:54:24 INFO - #22 0x7fc63a94c650 in nsDocLoader::DocLoaderIsEmpty(bool) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:741:9 [task 2018-09-17T19:54:24.101Z] 19:54:24 INFO - #23 0x7fc63a94e811 in nsDocLoader::OnStopRequest(nsIRequest*, nsISupports*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:627:5 [task 2018-09-17T19:54:24.102Z] 19:54:24 INFO - #24 0x7fc63a94f65c in non-virtual thunk to nsDocLoader::OnStopRequest(nsIRequest*, nsISupports*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp [task 2018-09-17T19:54:24.111Z] 19:54:24 INFO - #25 0x7fc638c87753 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp:629:28 [task 2018-09-17T19:54:24.111Z] 19:54:24 INFO - #26 0x7fc638c83ed9 in mozilla::net::nsLoadGroup::Cancel(nsresult) /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp:258:15 [task 2018-09-17T19:54:24.112Z] 19:54:24 INFO - #27 0x7fc63a94bda9 in nsDocLoader::Stop() /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:241:22 [task 2018-09-17T19:54:24.113Z] 19:54:24 INFO - #28 0x7fc63a94bc30 in nsDocLoader::Stop() /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:238:3 [task 2018-09-17T19:54:24.114Z] 19:54:24 INFO - #29 0x7fc643a59754 in Stop /builds/worker/workspace/build/src/docshell/base/nsDocShell.h:192:25 [task 2018-09-17T19:54:24.115Z] 19:54:24 INFO - #30 0x7fc643a59754 in nsDocShell::Stop(unsigned int) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:5030 [task 2018-09-17T19:54:24.117Z] 19:54:24 INFO - #31 0x7fc643a7ca3d in nsDocShell::InternalLoad(nsIURI*, nsIURI*, mozilla::Maybe<nsCOMPtr<nsIURI> > const&, bool, bool, nsIURI*, unsigned int, nsIPrincipal*, nsIPrincipal*, unsigned int, nsTSubstring<char16_t> const&, char const*, nsTSubstring<char16_t> const&, nsIInputStream*, nsIInputStream*, unsigned int, nsISHEntry*, bool, nsTSubstring<char16_t> const&, nsIDocShell*, nsIURI*, nsIDocShell**, nsIRequest**) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp [task 2018-09-17T19:54:24.118Z] 19:54:24 INFO - #32 0x7fc643a761d4 in nsDocShell::LoadHistoryEntry(nsISHEntry*, unsigned int) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:12168:8 [task 2018-09-17T19:54:24.118Z] 19:54:24 INFO - #33 0x7fc643ab0833 in nsDocShell::Reload(unsigned int) /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr.h [task 2018-09-17T19:54:24.135Z] 19:54:24 INFO - #34 0x7fc63bc0802d in mozilla::dom::Location::Reload(bool) /builds/worker/workspace/build/src/dom/base/Location.cpp:873:25 [task 2018-09-17T19:54:24.137Z] 19:54:24 INFO - #35 0x7fc63c4fb7da in Reload /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Location.h:55:14 [task 2018-09-17T19:54:24.139Z] 19:54:24 INFO - #36 0x7fc63c4fb7da in mozilla::dom::Location_Binding::reload(JSContext*, JS::Handle<JSObject*>, mozilla::dom::Location*, JSJitMethodCallArgs const&) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/LocationBinding.cpp:955 [task 2018-09-17T19:54:24.148Z] 19:54:24 INFO - #37 0x7fc63e48ff9f in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/build/src/dom/bindings/BindingUtils.cpp:3296:13 [task 2018-09-17T19:54:24.150Z] 19:54:24 INFO - #38 0x7fc64622bceb in CallJSNative /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:461:15 [task 2018-09-17T19:54:24.152Z] 19:54:24 INFO - #39 0x7fc64622bceb in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:553 [task 2018-09-17T19:54:24.169Z] 19:54:24 INFO - #40 0x7fc644ab4832 in js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/workspace/build/src/js/src/jit/BaselineIC.cpp:3810:14 [task 2018-09-17T19:54:24.186Z] 19:54:24 INFO - #41 0x2d528815cdb7 (<unknown module>) [task 2018-09-17T19:54:24.187Z] 19:54:24 INFO - AddressSanitizer can not provide additional info. [task 2018-09-17T19:54:24.188Z] 19:54:24 INFO - SUMMARY: AddressSanitizer: ILL /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:40:19 in AnnotateMozCrashReason [task 2018-09-17T19:54:24.188Z] 19:54:24 INFO - ==1128==ABORTING [task 2018-09-17T19:54:24.289Z] 19:54:24 INFO - [Parent 984, Gecko_IOThread] WARNING: pipe error (77): Connection reset by peer: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 356 [task 2018-09-17T19:54:24.291Z] 19:54:24 INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x190084,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv [task 2018-09-17T19:54:24.293Z] 19:54:24 INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x190084,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv [task 2018-09-17T19:54:24.310Z] 19:54:24 INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x190084,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv [task 2018-09-17T19:54:24.413Z] 19:54:24 INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x910001,name=PVsync::Msg_Notify) Channel error: cannot send/recv [task 2018-09-17T19:54:24.482Z] 19:54:24 INFO - A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down [task 2018-09-17T19:54:25.072Z] 19:54:25 INFO - JavaScript error: resource://reftest/reftest.jsm, line 1558: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString] [task 2018-09-17T19:54:25.113Z] 19:54:25 INFO - !!! error running onStopped callback: TypeError: callback is not a function [task 2018-09-17T19:54:25.190Z] 19:54:25 INFO - JavaScript error: resource://reftest/reftest.jsm, line 1558: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString] [task 2018-09-17T19:54:25.531Z] 19:54:25 INFO - 1537214065520 Marionette DEBUG Received observer notification xpcom-will-shutdown [task 2018-09-17T19:54:25.531Z] 19:54:25 INFO - 1537214065521 Marionette INFO Stopped listening on port 2828 [task 2018-09-17T19:54:25.532Z] 19:54:25 INFO - 1537214065521 Marionette DEBUG Remote service is inactive [task 2018-09-17T19:54:26.565Z] 19:54:26 INFO - REFTEST INFO | Process mode: e10s [task 2018-09-17T19:54:26.566Z] 19:54:26 WARNING - leakcheck | refcount logging is off, so leaks can't be detected! [task 2018-09-17T19:54:26.628Z] 19:54:26 INFO - Return code: 0 [task 2018-09-17T19:54:26.629Z] 19:54:26 ERROR - No suite end message was emitted by this harness. [task 2018-09-17T19:54:26.630Z] 19:54:26 INFO - TinderboxPrint: reftest-crashtest<br/>3441/0/0 [task 2018-09-17T19:54:26.631Z] 19:54:26 ERROR - # TBPL FAILURE # [task 2018-09-17T19:54:26.631Z] 19:54:26 WARNING - setting return code to 2 [task 2018-09-17T19:54:26.632Z] 19:54:26 ERROR - The reftest suite: crashtest ran with return status: FAILURE Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=crashtest&revision=9205d38f866cc1e50cb67c87fe2a02654cde8417 Backout: https://hg.mozilla.org/integration/autoland/rev/6c0e298370b806722bceb4ea0242f50899490725
Flags: needinfo?(bzbarsky)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Hrm. The patch was green on try with linux64, which suggests that this test is testing different things on linux32 and linux64.... I'll try to adjust the asserts to be a bit more conservative, I guess.
Flags: needinfo?(bzbarsky)
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9009643 [details] Bug 1491313. Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8,jandem Andrew McCreight [:mccr8] has been removed from the revision.
Attachment #9009643 -
Flags: review+
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9009643 [details] Bug 1491313. Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8,jandem Jan de Mooij [:jandem] has been removed from the revision.
|
|
||
Comment 9•6 years ago
|
||
Comment on attachment 9009643 [details] Bug 1491313. Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8,jandem Andrew McCreight [:mccr8] has approved the revision.
Attachment #9009643 -
Flags: review+
|
||
Comment 10•6 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6561bbf2c1f Add some MOZ_CRASH instrumentation to help figure out why ClearDocumentDependentSlots hits its MOZ_CRASH case. r=mccr8
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a6561bbf2c1f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Comment 12•6 years ago
|
||
these are already being hit a couple of times: https://crash-stats.mozilla.com/search/?moz_crash_reason=~1488480%2F1405521&_columns=moz_crash_reason&_columns=signature#crash-reports
|
|
Assignee | |
Comment 13•6 years ago
|
||
That's good! So a few of those are this: MOZ_CRASH(Looks like bug 1488480/1405521, with hashtable ops failing in Compartment::getOrCreateWrapper) A typical report is https://crash-stats.mozilla.com/report/index/458e512f-d5fb-40dc-8bff-010640180920 The relevant bits are: Available Virtual Memory 140,730,394,124,288 bytes Available Physical Memory 1,202,409,472 bytes System Memory Use Percentage 92 The other crash reports mostly have similar numbers (though one claims only 53% system memory use percentage). In any case, it's not obvious to me why the putWrapper() call would fail there. We're not _that_ low on memory, I would think. Jon, any idea why putWrapper is failing? Also, none of the putWrapper failures seem to have callstacks implicating the Window code. They're other random DOM objects.
Flags: needinfo?(jcoppeard)
|
|
||
Comment 14•6 years ago
|
||
That crash also has: Available Page File 3,358,720 bytes (3.36 MB) I've noticed that a lot of our OOM crashes can have otherwise okay looking numbers but the available page file is really small. There may be a memory report in that crash dump somewhere if it is worth figuring out where memory is going.
|
|
||
Comment 15•6 years ago
|
||
There's also a LowCommitSpaceEvents value of 3. Gabriele, maybe you would like to look at the memory stuff in this crash?
Flags: needinfo?(gsvelto)
|
|
Assignee | |
Comment 16•6 years ago
|
||
More interestingly, we have a few crashes like https://crash-stats.mozilla.com/report/index/81c5cd66-06b9-4bfe-98ad-1e8770180920 or https://crash-stats.mozilla.com/report/index/35534fa2-ba05-4353-bfe2-3b4820180920 or https://crash-stats.mozilla.com/report/index/12b89a4e-53dd-43bf-868c-934cf0180919 These are all failing the assert in Window_Binding::get_document while being called from ClearCachedDocumentValue, which is what we want to diagnose. In all those cases we're hitting CrashIfDocumentOrLocationWrapFailed, which means this code: obj = value->WrapObject(cx, givenProto); if (!obj) { // At this point, obj is null, so just return false. // Callers seem to be testing JS_IsExceptionPending(cx) to // figure out whether WrapObject() threw. CrashIfDocumentOrLocationWrapFailed<T>(); which is a codepath I was figuring wouldn't fail in bug 1405521 comment 1! I'd like to give this a few more days, and then if the basic pattern looks the same I will back this patch out and try adding more instrumentation to WrapObject.
|
||
Comment 17•6 years ago
|
||
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #13) > Jon, any idea why putWrapper is failing? This only fails if we are out of memory.
Flags: needinfo?(jcoppeard)
|
||
Comment 18•6 years ago
|
||
When looking at OOM crashes on 64-bit Windows the only number that matters is "Available Page File". That's the maximum amount of memory that Windows allows a process to commit (even if it never touches said memory!). This is also called "commit space" and that's why you have a LowCommitSpaceEvents annotation: the available memory tracker detected the low-memory scenario and had already sent three low-memory notifications trying to save Firefox from going OOM. That also means the machine had been in a low-memory situation for over 30 seconds. And obviously 3 MiB of commit space left is ridiculously low, it's a miracle we didn't go OOM long before. Recent nightly builds should have memory reports attached to OOM crashes most of the time, this one does: https://crash-stats.mozilla.com/report/index/ad5f7f43-c7cd-46a3-ab95-ce1520180920 Is there a way to access it from crash-stats? The raw dump tab has no way to access it.
Flags: needinfo?(gsvelto)
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•