Closed Bug 1491385 Opened Last year Closed Last year

Use the unique performance counter ids in about:performance

Categories

(Toolkit :: Performance Monitoring, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Bug 1477943 introduced counter ids per my request, as I wasn't able to differentiate workers or to take into account sub frames that were gone. Let's use them!
Attached patch PatchSplinter Review
With this patch, the "dispatches in the last seconds" column is now filled for sub-items (subframes of different origins, or workers).
And when a subitem disappears, we can now add the last known values of its counter to the parent item, so that the total of the parent item doesn't go down. This makes the sort order much more stable.

I also fixed a bug in how the 'oldest' variable was assigned, which caused new CPU hungry tabs to take up to 10 seconds to bubble up (now they'll go up within ~2s).

And I changed the unit from s to ms for values < 1s, to avoid showing 0.<something> numbers.
Attachment #9009194 - Flags: review?(felipc)
Attachment #9009194 - Flags: review?(felipc) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c921cc00eea3
Use performance counter ids in about:performance to display information for subitems and have a more stable sorting, r=felipe.
https://hg.mozilla.org/mozilla-central/rev/c921cc00eea3
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.