1491385 - Use the unique performance counter ids in about:performance

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Florian Quèze [:florian]]

Bug 1477943 introduced counter ids per my request, as I wasn't able to differentiate workers or to take into account sub frames that were gone. Let's use them!

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

With this patch, the "dispatches in the last seconds" column is now filled for sub-items (subframes of different origins, or workers).
And when a subitem disappears, we can now add the last known values of its counter to the parent item, so that the total of the parent item doesn't go down. This makes the sort order much more stable.

I also fixed a bug in how the 'oldest' variable was assigned, which caused new CPU hungry tabs to take up to 10 seconds to bubble up (now they'll go up within ~2s).

And I changed the unit from s to ms for values < 1s, to avoid showing 0.<something> numbers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c921cc00eea3
Use performance counter ids in about:performance to display information for subitems and have a more stable sorting, r=felipe.

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c921cc00eea3