1491388 - Ensure a newly registered userScript doesn't use a revoked blob url because of a js code string shared with an unregistered userScript

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue is a follow up for Bug 1437861:

when a js code string is shared between multiple registered userScripts, the resulting blob url is also shared between all these userScripts (when they are registered from the same extension context). 

We should ensure that a newly registered user script doesn't use a revoked blob url for a js code string shared with an unregistered userScript, and apply changes to the userScript tests to ensure that this behavior doesn't regress.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1491388 - Clear userScripts revoked urls and refresh sharedData contentScripts on register/unregister. r?mixedpuppy!

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9009196 [details]
Bug 1491388 - Clear userScripts revoked urls and refresh sharedData contentScripts on register/unregister. r?mixedpuppy!

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8e1ccdf01a5
Clear userScripts revoked urls and refresh sharedData contentScripts on register/unregister. r=mixedpuppy

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8e1ccdf01a5

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

STR to QA verify this bug:

- install the test extension from Bug 1437861 comment 44 and register a userScript with the same js code string for two or more times
- open a new tab that should trigger the registered userScript
- Expected behavior on fixed version: 
  the last registered script is matched and run as expected
- Actual behavior on the non-fixed version: 
  the registered script doesn't run because the blob url has been revoked when we have registered the same js code more than once

Comment 6

[Victor Carciu]

Verified as fixed following the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1491388#c5 . 

I will attach a before\after postfix screenshot.

Comment 7

[Victor Carciu]

Attachment: Before\after fix screenshot.