1491435 - Add support for temporal scalability in GMP and enable H.264 temporal scalability

Status: NEW

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

We would like to enable temporal scalability for H.264, but it looks like this will also require changes to GMP.

Comment 1

[Dan Minor [:dminor]]

Johnny has patches for this already. I'll help him get them landed.

Comment 2

[Johnny Lee]

Attachment: Added H.264 encoder temporal layer parameters.

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 9016365 [details] [diff] [review]
Added H.264 encoder temporal layer parameters.

Review of attachment 9016365 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please add your changes to the openh264 plugin here as well? It's difficult to evaluate what you have without seeing what you have done to the codec itself. Thanks!

::: dom/media/gmp/gmp-api/gmp-video-codec.h
@@ +104,5 @@
>    uint8_t        mPacketizationMode; // 0 or 1
>    struct GMPVideoCodecH264AVCC mAVCC; // holds a variable-sized struct GMPVideoCodecH264AVCC mAVCC;
>  };
>  
> +struct GMPVideoCodecH264EncTL

Is there a reason not to include this value in GMPCodecSpecificInfoH264?

@@ +193,5 @@
>  struct GMPCodecSpecificInfoH264 {
>    uint8_t mSimulcastIdx;
>  };
>  
> +struct GMPCodecSpecificInfoH264EncTL {

I think this struct could be placed inside GMPCodecSpecificInfoH264.

Comment 4

[Johnny Lee]

Ok. I can update the structs that way. When editing structs, is there anything that needs to be done to account for backwards compatibility?

Comment 5

[Johnny Lee]

Attachment: Reviesed H.264 encoder temporal layer parameters.

Simplified first attachment. Added temporal layer entries to existing structs rather than generating new structs.

Comment 6

[Johnny Lee]

Attachment: Temporal scalability edits in OpenH264.

Applied gmp-video-codec.h update in OpenH264 plugin code.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.