Closed Bug 1491455 Opened Last year Closed Last year

The Shield icon in the control centre appears to be squished

Categories

(Firefox :: Site Identity, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel])

Attachments

(5 files, 2 obsolete files)

Attached image Screenshot
Bryan told me that the Shield icon should be a bit larger.  See this screenshot.
Bryan, this is because the icon you provided has a bit of space on the sides. Can you upload one without?

Thanks!
Flags: needinfo?(bbell)
Priority: -- → P2
Whiteboard: [privacy-panel-64]
Attached image Screenshot after the fix (obsolete) —
Assignee: nobody → ehsan
(In reply to Johann Hofmann [:johannh] from comment #1)
> Bryan, this is because the icon you provided has a bit of space on the
> sides. Can you upload one without?
> 
> Thanks!

My patch works around it.  The security icon has the same problem...

(Or we could fix both icons.  If they both are made 24x24 and fill in the entire canvas then the problem would go away -- if that size if fine.)
(In reply to :Ehsan Akhgari from comment #4)
> (In reply to Johann Hofmann [:johannh] from comment #1)
> > Bryan, this is because the icon you provided has a bit of space on the
> > sides. Can you upload one without?
> > 
> > Thanks!
> 
> My patch works around it.  The security icon has the same problem...
> 
> (Or we could fix both icons.  If they both are made 24x24 and fill in the
> entire canvas then the problem would go away -- if that size if fine.)

Yeah, see comment on Phabricator (this is why comments should be mirrored), I think that's the preferable solution. We don't use that icon anywhere else.
Attachment #9009336 - Attachment is obsolete: true
Whiteboard: [privacy-panel-64] → [privacy-panel]
here's the replacement icon you need.
Flags: needinfo?(bbell)
Attached file lock-24.svg.zip
and one for the lock icon
Attachment #9009335 - Attachment is obsolete: true
Pascal, is it too late to update icons for 63?
Flags: needinfo?(pascalc)
If you land on nightly like today and request uplift in the process, I can look at that uplift request tomorrow or Monday morning before the merge (no promise though, we have several last minute uplift requests and we also need to minimize risk)
Flags: needinfo?(pascalc)
Summary: The Sheild icon in the control centre appears to be squished → The Shield icon in the control centre appears to be squished
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc9eacb12437
Update the security and content blocking icons in the control centre r=johannh
Sorry, this landed a bit late.  I'll nominate for uplift, but please feel free to say no if this throws a wrench into the release plans, no pressure.  :-)

Thanks!
Comment on attachment 9016882 [details]
Bug 1491455 - Update the security and content blocking icons in the control centre

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Unclear

User impact if declined: The Security and Content Blocking icons appear a bit squished in the control centre

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Icon update

String changes made/needed: None
Attachment #9016882 - Flags: approval-mozilla-beta?
Comment on attachment 9016882 [details]
Bug 1491455 - Update the security and content blocking icons in the control centre

Hi Ehsan, it's a bit late indeed as the patch isn't even on Nightly and we will build rc1 soon. The visual change is also very subtle so I think it can ride the trains and I also noticed in your second screenshot that the lock icon in the url bar seems now more different from the one in the doorhanger which is maybe unwanted from a UX perspective (maybe chrome://browser/skin/connection-secure.svg should be updated too?).
Attachment #9016882 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
https://hg.mozilla.org/mozilla-central/rev/fc9eacb12437
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.