149146 - Remove unused dependencies from makefile or use -zignore

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Build Config, defect)

Description

[Nidheesh Dubey]

You have a lot of shared object dependencies.  A pldd(1) reveals
    112 dependencies.  A poke around these dependencies reveals that
    many have their own dependencies that aren't required:

    % LD_PRELOAD=libCrun.so.1 LD_LIBRARY_PATH=.:.. ldd -rU libdocshell.so
    	libCrun.so.1 =>  /usr/lib/libCrun.so.1
    	libmozjs.so =>   ../libmozjs.so
		....
    unreferenced object=../libmozjs.so; unused dependency of ./libdocshell.so
    unused object=../libmozjs.so
    unreferenced object=../libplds4.so; unused dependency of ./libdocshell.so
    unreferenced object=../libplds4.so; unused dependency of ../libmozjs.so
    unreferenced object=../libplc4.so; unused dependency of ../libmozjs.so
    ...

    The important items to hit are things like libmozjs.so above.  This is
    unused by this group of objects, so why map it in the first place?
    The unreferenced dependencies also add some (but smaller) overhead.

    A goal should be to have any object define *all* the dependencies it
    needs - note above I had to preload libCrun to relocate the object
    completely, this really should be a dependency.  And, don't define
    any dependencies you don't need.  Either remove unused/unreferenced
    dependencies from your makefiles or use ld's -zignore option.

Comment 1

[Joe Chou]

Re-assign to Nidheesh.

Comment 2

[Roland Mainz]

Nidheesh Dubey:
Would using "-zignore" involve any risks ?

Comment 3

[Roland Mainz]

Nidheesh:
Can you make a patch to add -zignore to the build system, please ?

Comment 4

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 5

[Robert Kaiser]

I don't see any useful stuff in this bug for SeaMonkey specifically. Please file new bugs in the correct places if there are still issues.