1491529 - Restore footer image after bug 1471305

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1471305 removed the footer image we still use.

Maybe we can resurrect it or we need to work around with mirroring the main image.

Comment 1

[Tim Nguyen :ntim]

Does Thunderbird really need footer images ? additional_backgrounds apply to the footer as well according to bug 1486202. Can't that be an alternative ?

Comment 2

[Richard Marti (:Paenglab)]

It used it until now. additional_backgrounds would only work when there are additional backgrounds. Normal LW-themes have no such.

Comment 3

[Tim Nguyen :ntim]

(In reply to Richard Marti (:Paenglab) from comment #2)
> It used it until now. additional_backgrounds would only work when there are
> additional backgrounds. Normal LW-themes have no such.

LWT will be migrated to static WebExtension themes on AMO, and LWT support will get removed.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: statusbar-image.patch

This patch uses now the --lwt-header-image instead of the --lwt-footer-image. I positioned the image right bottom to show the bottom of the header image which is almost never seen and we can say, the bottom of the window can also show the bottom of the image. Like I implemented it, it works for multiple background images too.

Comment 5

[Jorg K (CEST = GMT+2)]

How do I test this? The WE theme [e-mail] or LW theme?

Comment 6

[Richard Marti (:Paenglab)]

Both, to be sure the multi backgrounds still work and how it looks with a normal LW-theme. "Japanese Tattoo" is a good LW-theme to see the statusbar image (the text colour isn't optimal but doesn't matter for this test).

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9011193 [details] [diff] [review]
statusbar-image.patch

Hmm, I don't see a difference with the WE theme [e-mail], It that expected? The "Tattoo" LW theme now shows something in the statusbar again.

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #7)
> Comment on attachment 9011193 [details] [diff] [review]
> statusbar-image.patch
> 
> Hmm, I don't see a difference with the WE theme [e-mail], It
> that expected? 

Yes, when you see all three TB icons then it is working as it should.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/185f455ddd94
Use differently positioned header image for the statusbar after the footer image removal in bug 1471305. r=jorgk