Closed
Bug 1491561
Opened 6 years ago
Closed 6 years ago
Remove the XPCOM registrations for LoadContext
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Priority: -- → P2
Comment 2•6 years ago
|
||
Comment on attachment 9009368 [details] Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.
Attachment #9009368 -
Flags: review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53 Remove the XPCOM registrations for LoadContext; r=bzbarsky
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ab80aaa53f9 follow-up: Fix a build problem
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53 https://hg.mozilla.org/mozilla-central/rev/3ab80aaa53f9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 6•6 years ago
|
||
Ehsan, why did you remove the code for Cu.createCommandParams() again here? https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30 Already like this on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53#l7.30 We started using it in bug 1492051 and now we're busted again :-(
Flags: needinfo?(ehsan)
Assignee | ||
Comment 7•6 years ago
|
||
Oh, wow, this must have somehow happened during rebasing, I honestly have no idea how even! I'll push a fix to inbound right now, sorry about this.
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb38b2b939c follow-up: Add back Cu.createCommandParams() which was accidentally removed
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aef48e938f89 follow-up: Build bustage fix
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fb38b2b939c https://hg.mozilla.org/mozilla-central/rev/aef48e938f89
You need to log in
before you can comment on or make changes to this bug.
Description
•