46 bytes, text/x-phabricator-request
|Details | Review|
Comment on attachment 9009368 [details] Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.
Attachment #9009368 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53 Remove the XPCOM registrations for LoadContext; r=bzbarsky
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ab80aaa53f9 follow-up: Fix a build problem
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Ehsan, why did you remove the code for Cu.createCommandParams() again here? https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30 Already like this on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53#l7.30 We started using it in bug 1492051 and now we're busted again :-(
Oh, wow, this must have somehow happened during rebasing, I honestly have no idea how even! I'll push a fix to inbound right now, sorry about this.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb38b2b939c follow-up: Add back Cu.createCommandParams() which was accidentally removed
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aef48e938f89 follow-up: Build bustage fix
You need to log in before you can comment on or make changes to this bug.