Remove the XPCOM registrations for LoadContext

RESOLVED FIXED in Firefox 64

Status

()

P2
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Priority: -- → P2
Comment on attachment 9009368 [details]
Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky

Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.
Attachment #9009368 - Flags: review+

Comment 3

6 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53
Remove the XPCOM registrations for LoadContext; r=bzbarsky

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53
https://hg.mozilla.org/mozilla-central/rev/3ab80aaa53f9
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Comment 6

6 months ago
Ehsan, why did you remove the code for Cu.createCommandParams() again here?
https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30

Already like this on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53#l7.30

We started using it in bug 1492051 and now we're busted again :-(
Flags: needinfo?(ehsan)
(Assignee)

Comment 7

6 months ago
Oh, wow, this must have somehow happened during rebasing, I honestly have no idea how even!

I'll push a fix to inbound right now, sorry about this.
Flags: needinfo?(ehsan)

Comment 8

6 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb38b2b939c
follow-up: Add back Cu.createCommandParams() which was accidentally removed
You need to log in before you can comment on or make changes to this bug.