1491561 - Remove the XPCOM registrations for LoadContext

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Comment 1

[(no longer active)]

Attachment: Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9009368 [details]
Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky

Boris Zbarsky [:bzbarsky, bz on IRC] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53
Remove the XPCOM registrations for LoadContext; r=bzbarsky

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ab80aaa53f9
follow-up: Fix a build problem

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53
https://hg.mozilla.org/mozilla-central/rev/3ab80aaa53f9

Comment 6

[Jorg K (CEST = GMT+2)]

Ehsan, why did you remove the code for Cu.createCommandParams() again here?
https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30

Already like this on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9a1e07a53#l7.30

We started using it in bug 1492051 and now we're busted again :-(

Comment 7

[(no longer active)]

Oh, wow, this must have somehow happened during rebasing, I honestly have no idea how even!

I'll push a fix to inbound right now, sorry about this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb38b2b939c
follow-up: Add back Cu.createCommandParams() which was accidentally removed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aef48e938f89
follow-up: Build bustage fix

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5fb38b2b939c
https://hg.mozilla.org/mozilla-central/rev/aef48e938f89