1491574 - Remove the XPCOM registration for nsProperties and nsPersistentProperties

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[(no longer active)]

Attachment: Bug 1491574 - Part 1: Remove the XPCOM registration for nsProperties; r=froydnj

Comment 2

[(no longer active)]

Attachment: Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj

Depends on D5949

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9009378 [details]
Bug 1491574 - Part 1: Remove the XPCOM registration for nsProperties; r=froydnj

Nathan Froyd [:froydnj] has approved the revision.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 9009379 [details]
Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj

Nathan Froyd [:froydnj] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e8f3f70f8b
Part 1: Remove the XPCOM registration for nsProperties; r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d11b69de826
Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5390b485f7e4
follow-up: Address more of the review comment

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out 3 changesets (Bug 1491574) for build bustage at builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0c26701ba0428481a9a0e5062cb921b7e5546d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=5390b485f7e4a5d0a9c138b0df0cf1ed5f0b40a8

Failure log:  https://treeherder.mozilla.org/logviewer.html#?job_id=199841615&repo=mozilla-inbound&lineNumber=16031

[task 2018-09-18T04:05:12.912Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/caps'
[task 2018-09-18T04:05:12.912Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/caps'
[task 2018-09-18T04:05:12.912Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/caps'
[task 2018-09-18T04:05:12.933Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/webrtc/video_engine/video_engine_gn'
[task 2018-09-18T04:05:12.933Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-gnu -o Unified_cpp_video_engine_gn0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG -DTRIMMED=1 -DCHROMIUM_BUILD -DEXPAT_RELATIVE_PATH -DV8_DEPRECATION_WARNINGS -DWEBRTC_MOZILLA_BUILD -DWEBRTC_RESTRICT_LOGGING -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNVALGRIND -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DWEBRTC_LINUX -DWEBRTC_POSIX -D_FILE_OFFSET_BITS=64 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/media/webrtc/trunk/webrtc/video_engine/video_engine_gn -I/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/webrtc/video_engine/video_engine_gn -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/media/webrtc/trunk -I/builds/worker/workspace/build/src/obj-firefox/dist/include -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer  -MD -MP -MF .deps/Unified_cpp_video_engine_gn0.o.pp   /builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/webrtc/video_engine/video_engine_gn/Unified_cpp_video_engine_gn0.cpp
[task 2018-09-18T04:05:12.934Z] 04:05:12     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/webrtc/video_engine/video_engine_gn/Unified_cpp_video_engine_gn0.cpp:2:
[task 2018-09-18T04:05:12.934Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/media/webrtc/trunk/webrtc/video_engine/desktop_capture_impl.cc:447:5: warning: field 'mRefCount' will be initialized after field 'capturer_thread_' [-Wreorder]
[task 2018-09-18T04:05:12.935Z] 04:05:12     INFO -      mRefCount(0),
[task 2018-09-18T04:05:12.937Z] 04:05:12     INFO -      ^
[task 2018-09-18T04:05:12.938Z] 04:05:12     INFO -  1 warning generated.
[task 2018-09-18T04:05:12.938Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/webrtc/video_engine/video_engine_gn'
[task 2018-09-18T04:05:12.939Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-09-18T04:05:12.940Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-gnu -o Unified_cpp_netwerk_base2.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/netwerk/socket -I/builds/worker/workspace/build/src/security/pkix/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_netwerk_base2.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/base/Unified_cpp_netwerk_base2.cpp
[task 2018-09-18T04:05:12.940Z] 04:05:12     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/netwerk/base/Unified_cpp_netwerk_base2.cpp:128:
[task 2018-09-18T04:05:12.940Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp:2036:16: error: no matching member function for call to 'swap'
[task 2018-09-18T04:05:12.941Z] 04:05:12     INFO -      properties.swap(*outResult);
[task 2018-09-18T04:05:12.941Z] 04:05:12     INFO -      ~~~~~~~~~~~^~~~
[task 2018-09-18T04:05:12.941Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:251:3: note: candidate function not viable: no known conversion from 'nsIPersistentProperties *' to 'RefPtr<nsPersistentProperties> &' for 1st argument
[task 2018-09-18T04:05:12.942Z] 04:05:12     INFO -    swap(RefPtr<T>& aRhs)
[task 2018-09-18T04:05:12.942Z] 04:05:12     INFO -    ^
[task 2018-09-18T04:05:12.942Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:260:3: note: candidate function not viable: no known conversion from 'nsIPersistentProperties *' to 'nsPersistentProperties *&' for 1st argument
[task 2018-09-18T04:05:12.942Z] 04:05:12     INFO -    swap(T*& aRhs)
[task 2018-09-18T04:05:12.942Z] 04:05:12     INFO -    ^
[task 2018-09-18T04:05:12.943Z] 04:05:12     INFO -  1 error generated.
[task 2018-09-18T04:05:12.943Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1121: recipe for target 'Unified_cpp_netwerk_base2.o' failed
[task 2018-09-18T04:05:12.943Z] 04:05:12     INFO -  make[4]: *** [Unified_cpp_netwerk_base2.o] Error 1
[task 2018-09-18T04:05:12.943Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-09-18T04:05:12.944Z] 04:05:12     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'netwerk/base/target' failed
[task 2018-09-18T04:05:12.944Z] 04:05:12     INFO -  make[3]: *** [netwerk/base/target] Error 2
[task 2018-09-18T04:05:12.944Z] 04:05:12     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-09-18T04:05:12.944Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/uriloader/exthandler'
[task 2018-09-18T04:05:12.945Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/uriloader/exthandler'
[task 2018-09-18T04:05:12.945Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/mtransport/build'
[task 2018-09-18T04:05:12.945Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/mtransport/build'
[task 2018-09-18T04:05:12.945Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/uriloader/exthandler'
[task 2018-09-18T04:05:12.946Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/uriloader/exthandler'
[task 2018-09-18T04:05:12.946Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/mtransport/build'
[task 2018-09-18T04:05:12.946Z] 04:05:12     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/mtransport/build'
[task 2018-09-18T04:05:12.962Z] 04:05:12     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/testing/gtest/benchmark'

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b9564e6f967
Part 1: Remove the XPCOM registration for nsProperties; r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/930f94ff8388
Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1b9564e6f967
https://hg.mozilla.org/mozilla-central/rev/930f94ff8388