1491646 - Buttons disappears when changing language

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[rolf.back]

Attachment: firefox-bug.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180830143136

Steps to reproduce:

I've managed to remove all languages earlier and want save a new setting.

Settings - Language


Actual results:

The buttons Ok, Cancel and Help are visible when popup is displayed but dissapears when language is added to the list. I cannot save my new setting.


Expected results:

The buttons should be visible and I should be able to save my setting.

Comment 1

[Alice0775 White]

It seems to have already been fixed in Firefox beta63.

Comment 2

[Mike Taylor [:miketaylr]]

Can you verify it's fixed in Beta 63?

Comment 3

[Mike Taylor [:miketaylr]]

Brindusa, can you do a mozregression --findfix here (or find someone?) thank!

Comment 4

[rolf.back]

(In reply to Mike Taylor [:miketaylr] (62 Regression Engineering Owner) from comment #2)
> Can you verify it's fixed in Beta 63?

Yes - it's fixed in beta.

Comment 5

[Mike Taylor [:miketaylr]]

Thanks. Depending on the patch that fixed this, it might be worth riding along in a dot release. It's pretty bad to not have OK/Cancel buttons...

Comment 6

[Daniel Bodea [:danibodea]]

Mozregression only works with Nightly, not Beta, so I have found a bad build in Nightly and performed a mozregression with the find-fix argument; this is the pushlog of the fix:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3587c059bdd04fa2289c250817c8742f0c2700fe&tochange=bd747e24063da7d803dc5fd20b5a8af0d036f4d5

Note that this issue also occurs on the Mac OS and Ubuntu operating systems, but it's most visible on Windows.
Please let me know if I can help any more.

Comment 7

[:Gijs (he/him)]

Looks like bug 1472716 fixed this. Paolo, how would you feel about that being a potential dot-release ride-along for 62?

Comment 8

[:Paolo Amadini]

Well, this seems a risky uplift to me, given that we had to make some Fluent changes for the patch to work, and I'm not sure we have all the localization elements in place on earlier trains. Maybe this will work fine, and if warranted, we can try and do some QA around it, but it's not a risk-free uplift for Release.

Comment 9

[:Gijs (he/him)]

Sounds like it's too late to do anything about this for 62, but it's already fixed in 63 and later. Going to mark this WFM and mark 62 as wontfix based on comment #8, then. Thanks, Paolo!

Comment 10

[Mike Taylor [:miketaylr]]

thanks all!