1491649 - long dropdown texts cropped/shortened in responsive design mode for device and connection type due to too small width

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot responsive design mode dropdown texts cropped

Firefox 64.0a1 20180914100156 on Windows 8.1

The longest options for both the simulated device and connection type have their labels cropped.

The dropdowns should have a width which allows all options to be shown in full length.

Comment 2

[Megan Bailey]

I'll be happy to take a look at this and fix it.

Comment 3

[Micah [:mtigley] (she/her)]

Thanks Megan! I'll assign this to you now.

Feel free to reach out if you have any questions!

Comment 4

[Megan Bailey]

Attachment: Bug 1491649 - Make useragent toolbar device and throlling select longer to display clearly. r=mtigley

Comment 5

[Victoria Wang [:victoria]]

Pinging this bug as it would be awesome to see this reviewed/landed :). Micah, any thoughts?

Comment 6

[Micah [:mtigley] (she/her)]

There are a few suggestions I made on the patch that I think just need to be submitted by Megan. Afterward, I think this will be good to go.

Comment 7

[Megan Bailey]

Hey, so I know this one has shown up in phab. For some reason, this bug and my other one will not let me push fixes separately. Even using the hashes, it submits both. I'm finishing this up now and will resubmit.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a23648c38e1
Make useragent toolbar device and throlling select longer to display clearly. r=mtigley

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0a23648c38e1

Comment 10

[Cristian Fogel [:cfogel]]

Confirmed issue with a build from 63.0a1 (2018-08-26) .
Verified fix with 71.0b5 on Windows 10, macOS 10.15, Ubuntu 18.04.