1491689 - Menu buttons in summary dialog are displayed as simple buttons

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[[:MakeMyDay]]

When displaying an event in the summary dialog after accepting an inviation for it, the toolbar buttons to accept, tentatively accept or decline the participation are missing the dropmarker and thus don't allow the user to decide whether or not to send a reply anymore when making his choice. Maybe related, for toolbarbutton -moz-box-align is applied with stretched instead of center.

Works in ESR60, not on current tip. Maybe a regression from bug 1487765 or bug 1457218, so eventually already an issue in 6.5.

Richard, do you have any idea offhand what's we're missing here?

Comment 1

[Richard Marti (:Paenglab)]

Attachment: bug1491689.patch

This fixes it for me. TB 60 isn't affected, but please check to be sure.

Comment 2

[[:MakeMyDay]]

Comment on attachment 9009466 [details] [diff] [review]
bug1491689.patch

Review of attachment 9009466 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. So this is a regression from bug 1457218, right? In that case we need to uplift this to beta - esr worked without that.

::: calendar/base/content/dialogs/calendar-summary-dialog.xul
@@ +4,5 @@
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  -->
>  
>  <?xml-stylesheet type="text/css" href="chrome://global/skin/global.css"?>
> +<?xml-stylesheet type="text/css" href="chrome://messenger/content/bindings.css"?>

can you move that down after the several calendar includes?

Comment 3

[Richard Marti (:Paenglab)]

I'd like to leave it where it is. xul.css is also loaded as one of the first stylesheet and bindings.css has the rules which are removed from xul.css. Like this, following rules can override the styles easier.

Comment 4

[Jorg K (CEST = GMT+2)]

Please request beta uplift from Philipp asap.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/316140574f95
Fix menu buttons in summary dialog by adding bindings.css to calendar-summary-dialog.xul. r=MakeMyDay DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

TB 63 beta, Cal 6.5:
https://hg.mozilla.org/releases/comm-beta/rev/ceb83db10d93ce008d94d504827fc4b21c7f266c