1491744 - [a11y] Better label for the menu button in doorhanger notifications

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

STR (with the NVDA screen reader):
1. Open a page which requires login and enter username and password so the save password doorhanger appears.
2. Press f6 to focus the doorhanger.
3. Tab to the button to open the menu containing other actions.
Expected: NVDA says something like: "More options  button  sub Menu"
Actual: NVDA says something like: "Would you like Nightly to save this login for foobar.com?  button  subMenu"

This button having the title of the notification as its label (for accessibility purposes) is very confusing for users. It's not clear that this pops up a menu with additional actions. It's also very verbose. This should be given a label like "More options", or "More actions". This can be done using the aria-label attribute. This will need to be a localised string.

The aria-label attribute can be added here:
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/notification.xml#536

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1491744 - Give the More Actions button and popup menu in doorhanger notifications a better accessibility label, r=gijs

When screen readers speak the button and subsequent menu when it pops up, the current full prompt is spoken by screen readers. This patch adds a localizable string that is spoken for both instances instead, but it not being displayed visually. This streamlines and improves the screen reader experience for this control and its menu popup a lot.

Comment 2

[:Gijs (he/him)]

Comment on attachment 9009550 [details]
Bug 1491744 - Give the More Actions button and popup menu in doorhanger notifications a better accessibility label, r=gijs

:Gijs (he/him) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b62c236e468
Give the More Actions button and popup menu in doorhanger notifications a better accessibility label, r=Gijs

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2b62c236e468

Comment 5

[Anca Soncutean, Desktop QA]

I reproduced this issue on Windows 10 x64 and macOS 10.13 with Fx 64.0a1 (20180916100118).
On Fx 64.0b4 (20181025233934) the other actions button is verbalized as following: Windows 10 x64 - “More options  button  submenu” , macOS 10.13 - “More actions button” and Ubuntu 18 x64 - “More actions menu button”. Therefore, I will mark this issue as verified fixed.