1491764 - [remote-dbg-next] Follow up to Network Locations support

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Comments from Bug 1483497 reviews

- to keep consistency with debugLocalAddon, maybe we should do the call to getAddonForm from debugRemoteAddon itself
  => need to check impact on existing about:debugging
- in other parts of the code we were disconnecting by removing the client key from the state. Here we are setting the ID of the runtime to null. [...] maybe it'd be good to have some consistency to represent voidness (https://phabricator.services.mozilla.com/D5136)
- mutualize reducer code in runtimes-state.js (https://phabricator.services.mozilla.com/D5135)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: expand-triangle-disappears.gif

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1491764 - Update debugRemoteAddon to accept addonID as parameter;r=ladybenko

The call to getAddonForm has been inline in debugRemoteAddon.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1491764 - Remove unused networkRuntimes parameter from RuntimesState constructor;r=ladybenko

Depends on D7307. This was not mentioned in the bug description but
this cleanup is also related to support of network locations runtime.
The RuntimesState() method accepts a networkRuntimes parameter at the 
moment, but it is never provided.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1491764 - Mutualize runtimes reducer logic to update single runtime;r=ladybenko

Depends on D7308 . This changeset introduces a common helper
to modify a single runtime in the list of runtimes.

Comment 5

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=73feb64ee3776f44c6edbcf7995595703a9d8d2e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e260539c399
Update debugRemoteAddon to accept addonID as parameter;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/594454d6b1cc
Remove unused networkRuntimes parameter from RuntimesState constructor;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/6a2f74caa1c2
Mutualize runtimes reducer logic to update single runtime;r=ladybenko

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3e260539c399
https://hg.mozilla.org/mozilla-central/rev/594454d6b1cc
https://hg.mozilla.org/mozilla-central/rev/6a2f74caa1c2