[remote-dbg-next] Follow up to Network Locations support

RESOLVED FIXED in Firefox 64

Status

enhancement
P1
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 64
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

8 months ago
Comments from Bug 1483497 reviews

- to keep consistency with debugLocalAddon, maybe we should do the call to getAddonForm from debugRemoteAddon itself
  => need to check impact on existing about:debugging
- in other parts of the code we were disconnecting by removing the client key from the state. Here we are setting the ID of the runtime to null. [...] maybe it'd be good to have some consistency to represent voidness (https://phabricator.services.mozilla.com/D5136)
- mutualize reducer code in runtimes-state.js (https://phabricator.services.mozilla.com/D5135)
Assignee

Comment 1

8 months ago
Posted image expand-triangle-disappears.gif (obsolete) —
Assignee

Updated

8 months ago
Attachment #9009547 - Attachment is obsolete: true
Priority: P3 → P2
Assignee

Updated

8 months ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee

Comment 2

8 months ago
The call to getAddonForm has been inline in debugRemoteAddon.
Assignee

Comment 3

8 months ago
Depends on D7307. This was not mentioned in the bug description but
this cleanup is also related to support of network locations runtime.
The RuntimesState() method accepts a networkRuntimes parameter at the 
moment, but it is never provided.
Assignee

Comment 4

8 months ago
Depends on D7308 . This changeset introduces a common helper
to modify a single runtime in the list of runtimes.

Comment 6

8 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e260539c399
Update debugRemoteAddon to accept addonID as parameter;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/594454d6b1cc
Remove unused networkRuntimes parameter from RuntimesState constructor;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/6a2f74caa1c2
Mutualize runtimes reducer logic to update single runtime;r=ladybenko

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e260539c399
https://hg.mozilla.org/mozilla-central/rev/594454d6b1cc
https://hg.mozilla.org/mozilla-central/rev/6a2f74caa1c2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.