1491766 - Enable selftest.py on Mac

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mark Banner (:standard8)]

Bug 1255588 originally disabled testing/xpcshell/selftest.py on Mac as not all our builders were on 10.7.

As that is no longer the case, I believe this can now be enabled. I'm running a patch through try server.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1491766 - Enable selftest.py on Mac now that all our builds are later than 10.7.

Comment 2

[Mark Banner (:standard8)]

Andrew, I did a couple of try pushes for this, but I couldn't get them to show the test passing or failing. I'm wondering if python 3 is enabled on those and hence it is being skipped, or if they just aren't running the test suite for some reason.

Push of the patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=012c644df728861396ebfe7b3f7d672d145640b5
Push of the patch + patch to intentionally break the test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1042bc5b2547368e89c58dff22616e8541800095

Comment 3

[Andrew Halberstadt [:ahal]]

Unfortunately we don't run `python-test` tasks anywhere on Mac at the moment :(

The builds are cross-compiled from Linux, so we can't use "make check" like we do for Windows. And the individual python-test tasks you see on Linux don't have the ability to run on OSX yet (bug 1436037 tracks fixing this). I think fixing this should be a high priority, and lots of people are blocked on it but so far no one has had the time to get it working. I may take another stab at it sometime soon.

In the meantime there's not much you can do. I'd recommend testing locally and if it works removing that skip-if key without testing on try. If there's a failure we'll sort it out when we eventually get tests running on OSX.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 9009566 [details]
Bug 1491766 - Enable selftest.py on Mac now that all our builds are later than 10.7.

Andrew Halberstadt [:ahal] has approved the revision.

Comment 5

[Mark Banner (:standard8)]

Yeah, locally it works fine. So lets land this for now, and then it'll not be forgotten.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b017cc976119
Enable selftest.py on Mac now that all our builds are later than 10.7. r=ahal

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b017cc976119