Closed Bug 1491767 Opened 7 years ago Closed 7 years ago

purge-caches errors are not readable

Categories

(Taskcluster :: UI, defect)

Product:
Taskcluster
Component:
UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: marco, Assigned: hrushikeshcoc)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Screenshot from 2018-12-08 10-07-45.png
62.14 KB, image/png
Details
E.g. if you don't fill Provisioner ID and Worker Type, you get `Error executing operation: TypeError: NetworkError when attempting to fetch resource.`
Fixing this would start with reproducing the error, watching in the network inspector to see what's going wrong.
Component: General → Tools
Keywords: good-first-bug
Hello everyone! May I please work on this bug in case no one is working on it? I have little experience in Node.js and Express.js. So, it would be great if someone explains the workflow to me. Please do mention if I need to learn some new technology to resolve this bug. Thanks in advance!
Sure, Preeti! This may not even be a Node / Express-related bug! Start by trying to reproduce the error marco saw. If you can do that, have a look in the network inspector to see what kinds of requests the browser is making, and where it's getting this NetworkError. Then we can take it from there.
Assignee: nobody → preetimukherjee98
If the last comment wasn't clear, marco is the person who reported the bug (Marco Catelluccio). So I'm suggesting trying to see the same thing he saw.
(In reply to Marco Castelluccio [:marco] from comment #0) > E.g. if you don't fill Provisioner ID and Worker Type, you get `Error > executing operation: TypeError: NetworkError when attempting to fetch > resource.` I have set up taskcluster on my local machine, however, could you please tell me where do you find the Provisioner ID and Worker Type? I signed in using random client id and access token. I used the code from the github repo on taskcluster-web. Please do let me know, if I need to get the codebase from anywhere else. Thanks in advance!
Ah, I just connected your questions in irc to this bug, sorry. The bug is in taskcluster-tools, rather than taskcluster-web. Taskcluster-web is still a work in progress and not yet active. The reproduction on the "real" site is: Go to https://tools.taskcluster.net/purge-caches Click "Create Request" Once you've got taskcluster-tools running locally, you should be able to do the same there. There is no need to sign in at all.
(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #6) > Ah, I just connected your questions in irc to this bug, sorry. The bug is > in taskcluster-tools, rather than taskcluster-web. Taskcluster-web is still > a work in progress and not yet active. > > The reproduction on the "real" site is: > Go to https://tools.taskcluster.net/purge-caches > Click "Create Request" > > Once you've got taskcluster-tools running locally, you should be able to do > the same there. There is no need to sign in at all. Yes I do see the error message right now! Thank you Dustin! Now please do let me know how to proceed with the bug. Thanks in advance!
Well, see if you can figure out why we're getting a TypeError and NetworkError. The network inspector might help figure out what error you're getting via HTTP.
(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #8) > Well, see if you can figure out why we're getting a TypeError and > NetworkError. The network inspector might help figure out what error you're > getting via HTTP. Sorry for my delayed response, could you please tell me how do I find out the HTTP error? I saw the network inspector section, however I could not realise, which one meant the HTTP error. Thanks in advance!
In HTTP, any response code 400 or higher is considered an error. The network inspector shows the response code in the left of the display. So when you click the button to purge caches with no input, you should see some HTTP requests added in that view, and likely one or more of them has an error response code. Click on that request to see more details, such as the response body (which should describe the error).
I am gettin a 404 error.Please do tell me, how to proceed now? Thanks in advance!
Great! Well, that's not what the UI shows, so the next step is to figure out what is causing that discrepancy. Dig in, figure out what's going on, then fix the issue :)
Assignee: preetimukherjee98 → nobody
Sounds good!
Assignee: nobody → hrushikeshcoc
I tried make a purge request in chrome. the error that i received was : " Error executing operation: TypeError: Failed to fetch ". Whereas on Firefox the error is " Error executing operation: TypeError: NetworkError when attempting to fetch resource. " I think this is not a bug with tc-tools rather its a bug within firefox. I found a similar thing here : https://bugzilla.mozilla.org/show_bug.cgi?id=1346447 . Can you point out what i should do next?
Those sound like different ways of writing the same error. As that bug mentions, fetch errors are necessarily vague. Here's what I see in the network console - 404's. I think that the problem is that those 404 responses do not have the right Access-Control-Allow-Origin headers (which is a bug on the server). So in tools, the right fix is to disable the button until all of the fields are filled in. Can you give that a try?
I have made the fix that you requested. Making a PR for this now.
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools https://github.com/taskcluster/taskcluster-tools/commit/58bc1776d2dcf8e800f3c934219f0da97c85b551 Bug 1491767 : Disable Create Request Button in purge cache when fields are empty (#593)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Tools → UI and Tools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: