Add the cranelift flag to js/src/shell/fuzz-flags.txt

RESOLVED FIXED in Firefox 69

Status

()

enhancement
P2
normal
RESOLVED FIXED
11 months ago
2 months ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 wontfix, firefox69 fixed)

Details

Attachments

(2 attachments)

Cranelift will soonly be built and enabled by default on Nightly (--enable-cranelift on the configure line for non-Nightlies). As suggested by Gary, this bug is a reminder to add the shell flag to use it for wasm in the fuzz-flags.txt file, as well as ping the fuzzers that we should test it :) (when things land).
Posted patch fix.patchSplinter Review
Here's the trivial fix; but before we start fuzzing Cranelift in spidermonkey, we should probably fix a few known bugs (like https://github.com/CraneStation/cranelift/issues/335 ).
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED

Benjamin, that CL issue appears to be fixed now, should we continue trying to land this patch?

Flags: needinfo?(bbouvier)
Priority: -- → P2

Indeed, thanks for the ping!

Flags: needinfo?(bbouvier)
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de70a3fa29db
Add Cranelift to the list of Spidermonkey fuzzing configurations; r=lth
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

I seem to recall --wasm-compiler=baseline+cranelift being another possible combination. Should this also be added?

Flags: needinfo?(bbouvier)

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #7)

I seem to recall --wasm-compiler=baseline+cranelift being another possible combination. Should this also be added?

I expect this to be of much lower importance; if we could weight combinations, it would be very low. We might add it later, though. Thanks for checking!

Flags: needinfo?(bbouvier)
You need to log in before you can comment on or make changes to this bug.