Closed
Bug 1491770
Opened 6 years ago
Closed 5 years ago
Add the cranelift flag to js/src/shell/fuzz-flags.txt
Categories
(Core :: JavaScript: WebAssembly, enhancement, P2)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla69
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files)
725 bytes,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Cranelift will soonly be built and enabled by default on Nightly (--enable-cranelift on the configure line for non-Nightlies). As suggested by Gary, this bug is a reminder to add the shell flag to use it for wasm in the fuzz-flags.txt file, as well as ping the fuzzers that we should test it :) (when things land).
Assignee | ||
Comment 1•6 years ago
|
||
Here's the trivial fix; but before we start fuzzing Cranelift in spidermonkey, we should probably fix a few known bugs (like https://github.com/CraneStation/cranelift/issues/335 ).
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Benjamin, that CL issue appears to be fixed now, should we continue trying to land this patch?
Flags: needinfo?(bbouvier)
Priority: -- → P2
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de70a3fa29db Add Cranelift to the list of Spidermonkey fuzzing configurations; r=lth
Comment 6•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
I seem to recall --wasm-compiler=baseline+cranelift
being another possible combination. Should this also be added?
Flags: needinfo?(bbouvier)
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #7)
I seem to recall
--wasm-compiler=baseline+cranelift
being another possible combination. Should this also be added?
I expect this to be of much lower importance; if we could weight combinations, it would be very low. We might add it later, though. Thanks for checking!
Flags: needinfo?(bbouvier)
You need to log in
before you can comment on or make changes to this bug.
Description
•