1491770 - Add the cranelift flag to js/src/shell/fuzz-flags.txt

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Cranelift will soonly be built and enabled by default on Nightly (--enable-cranelift on the configure line for non-Nightlies). As suggested by Gary, this bug is a reminder to add the shell flag to use it for wasm in the fuzz-flags.txt file, as well as ping the fuzzers that we should test it :) (when things land).

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fix.patch

Here's the trivial fix; but before we start fuzzing Cranelift in spidermonkey, we should probably fix a few known bugs (like https://github.com/CraneStation/cranelift/issues/335 ).

Comment 2

[Lars T Hansen [:lth]]

Benjamin, that CL issue appears to be fixed now, should we continue trying to land this patch?

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1491770: Add Cranelift to the list of Spidermonkey fuzzing configurations; r?lth

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Indeed, thanks for the ping!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de70a3fa29db
Add Cranelift to the list of Spidermonkey fuzzing configurations; r=lth

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/de70a3fa29db

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I seem to recall --wasm-compiler=baseline+cranelift being another possible combination. Should this also be added?

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #7)

I seem to recall --wasm-compiler=baseline+cranelift being another possible combination. Should this also be added?

I expect this to be of much lower importance; if we could weight combinations, it would be very low. We might add it later, though. Thanks for checking!