1491776 - Typing a non-alpha character insert it after the completion text for a brief moment

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: entered character displayed after completion text

**Steps to reproduce**
1. Open the console
2. Type `doc`
3. The completion text should be visible (with `ument`.
4. Type `;`

**Actual results**

For a very brief moment, the input looks like `document;` (where `ument` is in grey), before switching to `doc;`.
This results in a flash of styling which looks weird (see attachment).

---

This is probably because of the way we use markText in the editor.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: screenshot of the issue

Here's a still of what's visible just after typing `;`. It's only displayed for some milliseconds.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1491776 - Do not use markText to show the completion text; r=bgrins.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

TRY is fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=e532475fc94e8117b15a4eea6d9f27e93a2b38e0

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY push when keeping the markText approach: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4264ce9e120e2ca9d9eb681850d7e21af07300e5&selectedJob=199881206

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 9009579 [details]
Bug 1491776 - Do not use markText to show the completion text; r=bgrins.

Brian Grinstead [:bgrins] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83af3bf2f967
Do not use markText to show the completion text; r=bgrins.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/83af3bf2f967