Closed Bug 1491782 Opened Last year Closed Last year

Treat unrecognized user_scripts manifest keys as warnings instead of errors.

Categories

(WebExtensions :: General, enhancement, P2)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Iteration:
64.2 - Sep 28
Tracking Status
firefox64 --- fixed

People

(Reporter: robwu, Assigned: rpl)

References

Details

Attachments

(1 file)

The "user_scripts" manifest key should warn on unrecognized properties rather than treating it as an error, because the latter prevents the extension from being loaded in Firefox.
Doing so allows us to add new features to user_scripts, without forcing extension authors to drop support for earlier Firefox versions if they want to use that new property.

This can be done by adding
"additionalProperties": { "$ref": "UnrecognizedProperty" },

to https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/toolkit/components/extensions/schemas/user_scripts.json#12

We already do this for many manifest keys, including content_scripts:
https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/toolkit/components/extensions/schemas/manifest.json#514
Comment on attachment 9009571 [details]
Bug 1491782 - Allow unrecognized user_scripts manifest properties. r?robwu

Rob Wu [:robwu] has approved the revision.
Attachment #9009571 - Flags: review+
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Iteration: --- → 64.2 (Sep 28)
Priority: -- → P2
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/d2cc7e1a6745
Allow unrecognized user_scripts manifest properties. r=robwu
I'm marking this issue as qe-verify-, as it is tested in the automated tests.
Flags: qe-verify-
https://hg.mozilla.org/mozilla-central/rev/d2cc7e1a6745
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.