1491782 - Treat unrecognized user_scripts manifest keys as warnings instead of errors.

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Rob Wu [:robwu]]

The "user_scripts" manifest key should warn on unrecognized properties rather than treating it as an error, because the latter prevents the extension from being loaded in Firefox.
Doing so allows us to add new features to user_scripts, without forcing extension authors to drop support for earlier Firefox versions if they want to use that new property.

This can be done by adding
"additionalProperties": { "$ref": "UnrecognizedProperty" },

to https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/toolkit/components/extensions/schemas/user_scripts.json#12

We already do this for many manifest keys, including content_scripts:
https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/toolkit/components/extensions/schemas/manifest.json#514

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1491782 - Allow unrecognized user_scripts manifest properties. r?robwu

Comment 2

[Rob Wu [:robwu]]

Comment on attachment 9009571 [details]
Bug 1491782 - Allow unrecognized user_scripts manifest properties. r?robwu

Rob Wu [:robwu] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2cc7e1a6745
Allow unrecognized user_scripts manifest properties. r=robwu

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm marking this issue as qe-verify-, as it is tested in the automated tests.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d2cc7e1a6745