Closed Bug 1491785 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13025 - [css-contain] Layout and size containment and baseline alignment

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13025 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13025
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Layout and size containment and baseline alignment
>  
>  The CSSWG has recently resolved that layout containment
>  suppress baseline alignment, while size containment does not:
>  https://github.com/w3c/csswg-drafts/issues/2995
>  
>  Spec text (https://drafts.csswg.org/css-contain/#containment-layout):
>    "7. For the purpose of the vertical-align property,
>     or any other property whose effects need to relate
>     the position of the containing element's baseline
>     to something other than its descendants,
>     the containing element is treated as having no baseline."
>  
>  And a note in (https://drafts.csswg.org/css-contain/#containment-size):
>    "Note: size containment does not suppress baseline alignment.
>     See layout containment for that."
>  
>  The patch is just a modification in the condition at
>  LayoutBlock::UseLogicalBottomMarginEdgeForInlineBlockBaseline().
>  
>  Some tests in the suite need minor modifications
>  due to the behavior change in order to match the references.
>  
>  One of the Mozilla tests is failing now, a bug was reported
>  to get it updated (https://bugzilla.mozilla.org/1491235).
>  
>  BUG=882333
>  TEST=external/wpt/css/css-contain/contain-layout-baseline-001.html
>  TEST=external/wpt/css/css-contain/contain-size-baseline-001.html
>  
>  Change-Id: I08f157bfbc7477777b2f0b0157d8f05d3a6219d6
>  Reviewed-on: https://chromium-review.googlesource.com/1226146
>  WPT-Export-Revision: a7f563200bc87f7398215ef66447a9932da83136
PR 13025 applied with additional changes from upstream: 1343a173b66a7ba398bcb47a74bc8bf81ed11d40
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 6 tests
PASS   : 1
FAIL   : 5

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-contain/contain-size-021.html: FAIL
/css/css-contain/contain-size-023.html: FAIL
/css/css-contain/contain-size-027.html: FAIL

New tests that have failures or other problems:
/css/css-contain/contain-layout-independent-formatting-context-002.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0f795fa265
[wpt PR 13025] - [css-contain] Layout and size containment and baseline alignment, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5133d586b5f
[wpt PR 13025] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/6f0f795fa265
https://hg.mozilla.org/mozilla-central/rev/b5133d586b5f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.