Use clang 7final to build firefox & clang-tidy

RESOLVED FIXED in Firefox -esr60

Status

enhancement
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

Trunk
mozilla64
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox63 fixed, firefox64 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Comment on attachment 9009577 [details]
Bug 1491788 - Use clang 7final to build firefox & clang-tidy r?glandium

Mike Hommey [:glandium] has approved the revision.
Attachment #9009577 - Flags: review+

Comment 7

7 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8a7b6a9621a
Use clang 7final to build firefox & clang-tidy r=glandium
Blocks: 1492663
(Assignee)

Updated

7 months ago
Assignee: nobody → sledru

Comment 9

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8a7b6a9621a
https://hg.mozilla.org/mozilla-central/rev/903b4fb3194d
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
(Assignee)

Comment 10

7 months ago
Comment on attachment 9009577 [details]
Bug 1491788 - Use clang 7final to build firefox & clang-tidy r?glandium

Just like we did here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1489096#c8

Approval Request Comment
[Feature/Bug causing the regression]: There is no specific issue that is motivating this uplift.
[User impact if declined]: We ship our first clang-cl release with an rc release. even if rc3 == final, it is still less confusing for everyone to use a final release instead of a rc3
[Is this code covered by automated tests?]: all the tests!
[Has the fix been verified in Nightly?]: 1 day
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: Just like what we have in beta currently
[String changes made/needed]: no
Attachment #9009577 - Flags: approval-mozilla-beta?
(Assignee)

Comment 12

7 months ago
No good reason, do you want me to fix that?
should take a few seconds
Flags: needinfo?(sledru)
Yeah we should be consistent.
(Assignee)

Updated

7 months ago
Depends on: 1493142
Comment on attachment 9009577 [details]
Bug 1491788 - Use clang 7final to build firefox & clang-tidy r?glandium

Uplift approved for 63 beta 9, thanks.
Attachment #9009577 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.