Closed Bug 1491801 Opened 1 year ago Closed 1 year ago

Use short SHA1 for git build info

Categories

(Testing :: geckodriver, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

We use a short SHA1 for hg, and we should use the same for git.
Depends on: 1491799
Assignee: nobody → ato
Status: NEW → ASSIGNED
We use a short SHA1 for hg, and we should use the same for git.

Because git-cinnabar does not support --short, we have to truncate
the SHA ourselves.
Attachment #9010441 - Flags: review?(hskupin)
I based the branch off inbound so the try may contain some unexpected
failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d1b828bb10bbf8226a110b8f6da5aace6e6c859
Comment on attachment 9010441 [details] [diff] [review]
geckodriver: use short sha1 for git build info

Review of attachment 9010441 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine if it hurts us too much. Otherwise I filed https://github.com/glandium/git-cinnabar/issues/203 to get it fixed upstream, which is what we should do anyway.
Attachment #9010441 - Flags: review?(hskupin) → review+
It obviously doesn’t “hurt” to use the full SHA, but I would like
builds from git repositories and hg repositories to be reproducible.
If the build from a git repository produces a message in --version,
they are not reproducible.
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb1c0195ac65
geckodriver: use short sha1 for git build info; r=whimboo
https://hg.mozilla.org/mozilla-central/rev/cb1c0195ac65
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.