1491819 - Verify fix against pings with canary client ID in nightly

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik]]

After bug 1489520 lands, we should verify that we see fewer pings with the canary client ID (meaning the patch actually fixes the problem).

We then need to decide on either:

1. Uplift to beta and verify it there too
2. Back-out optout ping changeset before release

Comment 1

[Jan-Erik Rediger [:janerik]]

Pascal:
We currently have an issue with Telemetry pings where we report wrong client IDs due to the optout ping we landed a while back. It's currently included in beta 63.
We have a potential fix on its way to nightly and, if we can verify that it works, want to uplift it to beta.
If it doesn't solve the issue, we plan to back-out the full change before release.

What's the deadline for uplifting the fix or removing the breaking code parts from beta before it hits release?

Comment 2

[Pascal Chevrel:pascalc]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)
> Pascal:
> We currently have an issue with Telemetry pings where we report wrong client
> IDs due to the optout ping we landed a while back. It's currently included
> in beta 63.
> We have a potential fix on its way to nightly and, if we can verify that it
> works, want to uplift it to beta.
> If it doesn't solve the issue, we plan to back-out the full change before
> release.
> 
> What's the deadline for uplifting the fix or removing the breaking code
> parts from beta before it hits release?

It would be good either uplift a patch or backout the offending patch during the Early Beta period, that is before beta 9, we have the go to build for beta 9  on Monday 24.

Comment 3

[Jan-Erik Rediger [:janerik]]

There's a large drop in pings with a canary client ID on nightly after this fix went in: https://sql.telemetry.mozilla.org/queries/58865#152915
My query didn't find pings with a build id including that fix and a canary client ID.
The number of pings per channel stayed consistent: https://sql.telemetry.mozilla.org/queries/59073#152966

:chutten took a brief look at the first query to double-check I did query the right thing (and helped me actually see that it's the expected outcome).

I propose uplifting the fix from bug 1489520 to beta (and not reverting the optout ping completely).

Comment 4

[Georg Fritzsche [:gfritzsche]]

Is there a query that shows that on Nightly, by buildid, that no more canary client ids were submitted after this fix went in?
If yes and the query was reviewed (chutten?) this sounds good to me.

Comment 5

[Jan-Erik Rediger [:janerik]]

Change by buildid: https://sql.telemetry.mozilla.org/queries/59074#152972
Nightly builds before the fix: 0.2% of pings contain the canary client id
Nightly builds after the fix: 0% of pings contain the canary client id

Reviewed by :chutten.