1491859 - Migration fails silently when FTL in ctx.add_transforms is not well-formed

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: bug_1486936_about_config.py

Discovered while testing bug 1486936.


	ctx.add_transforms(
	"toolkit/toolkit/about/config.ftl",
	"toolkit/toolkit/about/config.ftl",
	transforms_from(
"""
  config-window =
  .title = { COPY(from_path, "window.title") }
  .aria-describedby = { COPY(from_path, "boolean.label") }
config-about-warning-title =
  .value = { COPY(from_path, "aboutWarningTitle.label") }
""", from_path="toolkit/chrome/global/config.dtd"))


This code fails silently: nothing is migrated, no errors in console. 

Note that the patch in bug 1486936 had another ctx.add_transforms defined, which is ignored as well.

Comment 1

[Axel Hecht [:Pike]]

I would expect that to say

  Skipping migration bug_1486936_about_config for test

flod, can you confirm?

Not that that's a great error message, but I'd like to confirm that the code behaves like I expect.

Comment 2

[Francesco Lodolo [:flod]]

You're right, it actually says that (I missed it when filing the bug, because I misnamed the file…)

Running migration bug_1486936_about_config for test
WARNING:migrate:Plural rule for "'test'" is not defined in compare-locales
  Skipping migration bug_1486936_about_config for test

Comment 3

[Axel Hecht [:Pike]]

Simple enough. The upcoming patch changes that to:

Running migration bug_1486936_about_config for test
WARNING:migrate:Plural rule for "'test'" is not defined in compare-locales
  Skipping migration bug_1486936_about_config for test:
    Transform contains parse error: Expected an entry start, at 1

Comment 4

[Axel Hecht [:Pike]]

Attachment: bug 1491859, expose underlying error when a transform fails, r=flod

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 9009650 [details]
bug 1491859, expose underlying error when a transform fails, r=flod

Francesco Lodolo [:flod] has approved the revision.

Comment 6

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/fluent-migration/rev/b27d1d2aa83e, marking FIXED.