1491865 - Show an 'Energy Impact' column instead of the 'dispatches' and 'duration' values

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Florian Quèze [:florian]]

Showing dispatches and duration currently exposes implementation details of how we are measuring performance impact of pages. For users it's easier to have a single number that's relatively correct, even if it doesn't have any precise technical meaning.

I'm trying to have the 'Energy Impact' number be close to '100' when a page is fully using a core, this way it'll look like a familiar percentage. It can of course go way above 100 for pages with workers.

To help users read the value, I'll also categorize the values as "High", "Medium", "Low" or "None" Energy impact.

This new value should be used for the default sorting.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9009647 [details] [diff] [review]
Patch

Review of attachment 9009647 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/aboutperformance/content/aboutPerformance.js
@@ +1102,5 @@
> +            return `Low (${energyImpact})`;
> +          if (energyImpact < 25)
> +            return `Medium (${energyImpact})`;
> +          return `High (${energyImpact})`;
> +        };

nit: both these functions would be better named "format" instead of make and display, since they only provided the formatted string.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2307c43683ba
Show an 'Energy Impact' column instead of the 'dispatches' and 'duration' values and sort based on it, r=felipe.

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2307c43683ba