1491907 - release-update-verify-config-thunderbird fails in gather-info

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

As mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1481095#c7, Thunderbird builds releases off comm-esr.* rather than comm-release. This is causing the 404 error seen below.

[task 2018-09-12T09:30:17.477Z] 09:30:17     INFO - retry: Calling _urlopen with args: (), kwargs: {'url': 'https://hg.mozilla.org/releases/comm-release/raw-file/THUNDERBIRD_60_0_RELEASE/mail/locales/shipped-locales'}, attempt #5
[task 2018-09-12T09:30:17.981Z] 09:30:17     INFO - retry: attempt #5 caught HTTPError exception: HTTP Error 404: Not Found
[task 2018-09-12T09:30:17.982Z] 09:30:17     INFO - [mozharness: 2018-09-12 09:30:17.982054Z] Finished gather-info step (failed)
[task 2018-09-12T09:30:17.982Z] 09:30:17    FATAL - Uncaught exception: Traceback (most recent call last):
[task 2018-09-12T09:30:17.982Z] 09:30:17    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 2076, in run
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -     self.run_action(action)
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 2015, in run_action
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 1955, in _possibly_run_method
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -     return getattr(self, method_name)()
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -   File "testing/mozharness/scripts/release/update-verify-config-creator.py", line 315, in gather_info
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -     self._get_update_paths()
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -   File "testing/mozharness/scripts/release/update-verify-config-creator.py", line 292, in _get_update_paths
[task 2018-09-12T09:30:17.983Z] 09:30:17    FATAL -     shipped_locales = ret.read().strip()
[task 2018-09-12T09:30:17.984Z] 09:30:17    FATAL - AttributeError: 'NoneType' object has no attribute 'read'
[task 2018-09-12T09:30:17.984Z] 09:30:17    FATAL - Running post_fatal callback...
[task 2018-09-12T09:30:17.984Z] 09:30:17    FATAL - Exiting -1

Comment 1

[Rob Lemley [:rjl]]

Attachment: mozilla-esr60_450118.patch

Patch so that taskgraph/decision.py can get the correct version of Thunderbird from its  copies of *version.txt.

Comment 2

[Rob Lemley [:rjl]]

Attachment: mozilla-esr60_450119.patch

Updates to update-verify-config-creator.py to set the correct URL for Thunderbird releases when getting information from HG repos.

Comment 3

[Rob Lemley [:rjl]]

This is a work in progress, saving here for anyone interested. Tom has suggested a couple of changes that I will be making.

Note that these patches are against mozilla-esr60. I'll port to mozilla-central when they're complete.

Comment 4

[Rob Lemley [:rjl]]

Attachment: WIP: Set correct branch URL for Thunderbird based on product-details

Thunderbird releases come from the comm-esr.* repositories rather than the
comm-release repository. This adds a special case for Thunderbird and sets
the branch URL correctly.

This is an updated version of the patch that uses branch_prefix == "comm" to identify
a thunderbird product what releases from a comm-esr.* repository.

Additionally, I updated the sorting of the release information that gets pulled
from product-details.mozilla.org. It now uses MozillaVersion in order to get the
sorting in actual reverse order.

Comment 5

[Rob Lemley [:rjl]]

Attachment: log_info.log

Output from running update-verify-config-creator.py locally.

Comment 6

[Rob Lemley [:rjl]]

Attachment: update-verify.cfg

Generated update-verify.cfg after changes.

Comment 7

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Add version.txt information to comm_taskcluster/__init__.py

The UVC task needs correct version information supplied to it from the
Taskcluster decision task. That information is exported here for
decision.py to pick up.

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Update UVC task configuration

This brings the UVC task configuration in line with what's expected for
corresponding M-C changes on this bug.

Depends on D6505

Comment 9

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Set correct branch URL for Thunderbird based on product-details r?bhearsum

Thunderbird releases come from the comm-esr.* repositories rather than the
comm-release repository. This adds a special case for Thunderbird and sets
the branch URL correctly.

This initial patch is based on the "product" key, the next update will look
at branch_prefix.

Comment 10

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Get comm/ version from comm/mail/*version.txt r?bhearsum

The release-update-verify-config task requires that the versions passed
to it match up with what's been released. The version of Thunderbird
does not necessarily match the Gecko version it's based on.

Depends on D6509

Comment 11

[[e-mail] (:bhearsum)]

Comment on attachment 9011001 [details]
Bug 1491907 - Set correct branch URL for Thunderbird based on product-details r?bhearsum

Ben Hearsum (:bhearsum) has approved the revision.

Comment 12

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Add product-dir to config.yml

This is used by the decision task to locate the correct version.txt and
app_version.txt files for products other than Firefox.
Needs the corresponding change to land in M-C before it can be applied.
No breakage should occur if M-C gets updated before C-C as this is listed
as an Optional field in config.py.

Comment 13

[Rob Lemley [:rjl]]

A few minor changes have been requested to the latest patch in Phabricator. I'll get those sorted out ASAP and resubmit.
- only read config.yml once
- make product_dir a top level property in config.yml
- adjust get_version and get_app_version in properties.py. Remove the constants from __init__.py and simplify the two functions.

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 9011002 [details]
Bug 1491907 - Get comm/ version from comm/mail/*version.txt r?bhearsum

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

Comment 15

[Rob Lemley [:rjl]]

Attachment: Bug 1491907 - Set correct branch URL for Thunderbird based on product-details r?bhearsum

Thunderbird releases come from the comm-esr.* repositories rather than the
comm-release repository. This adds a special case for Thunderbird and sets
the branch URL correctly.

This patch is based on the branch_prefix (comm or mozilla).

Updated to fix pylint errors.

Comment 16

[Rob Lemley [:rjl]]

There are three patches attached to this bug that are in Phabricator.
Attachment 9011001 [details]: Applies to M-C.
Attachment 9011002 [details]: Applies to M-C
Attachment 9011910 [details]: Applies to C-C

These don't apply to the ESR60 repositories so nicely. I can upload updated patches if necessary.

Comment 17

[Jorg K (CEST = GMT+2)]

Hmm, I could land the first patch via Lando, but the second one is awaiting Tom's review and can't be landed. Also, I think it would make sense to land them together, no idea how that works in Lando.

Any yes, patches that apply to m/c-esr60 would be good so I don't mess it up ;-)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9cf6e98fc4b
Set correct branch URL for Thunderbird based on product-details r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/b96cec26d463
Get comm/ version from comm/mail/*version.txt r=dustin

Comment 19

[Rob Lemley [:rjl]]

Attachment: [patch] C-C patch for esr60

Comment 20

[Rob Lemley [:rjl]]

Attachment: [patch] 1/2 M-C patch for esr60

Comment 21

[Rob Lemley [:rjl]]

Attachment: [patch] 2/2 M-C patch for esr60

Comment 22

[Rob Lemley [:rjl]]

Just uploaded the patches ported to *-esr60 trees. If there's any problems, please let me know.

Comment 23

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f9cf6e98fc4b
https://hg.mozilla.org/mozilla-central/rev/b96cec26d463

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/390588f44e2b
C-C part: Add product-dir to config.yml. r=jorgk

Comment 25

[Jorg K (CEST = GMT+2)]

For TB 60.2.1:
https://hg.mozilla.org/releases/mozilla-esr60/rev/f0a374b418e9b2464087541a9eca3959ce44926b (THUNDERBIRD_60_VERBRANCH)
https://hg.mozilla.org/releases/mozilla-esr60/rev/ef90e3410f3bea0976b85c0a8083bf1b06fe747b (THUNDERBIRD_60_VERBRANCH)
https://hg.mozilla.org/releases/comm-esr60/rev/3d21f43c8332d83e1b6c1f758a80135358a178e2

Comment 26

[Jorg K (CEST = GMT+2)]

Tom, who can grant M-B approval here?

Comment 27

[Jorg K (CEST = GMT+2)]

Comment on attachment 9011910 [details]
Bug 1491907 - Add product-dir to config.yml

Jorg K (GMT+2) has been removed from the revision.

Comment 28

[Tom Prince [:tomprince]]

a=tomprince for these. But it is probably best to direct these to relman going forward.

Comment 29

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/44e1682a49189e22120bc0451a37f3cb60100845
https://hg.mozilla.org/releases/mozilla-beta/rev/9dc81ba0d288d2a46f6e0ef4976563cfea9a1be6

Comment 30

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-beta/rev/e0a8155d0e6cc8ba45ca78735e7d4340c5667106

Comment 31

[Aki Sasaki (not active)]

Reopening, since we're backing these patches out of m-c/m-b for breaking Firefox update-verify-config tasks.

Comment 32

[Rob Lemley [:rjl]]

The fix applied in bug 1496480 does not affect comm-* code, nothing more needs to be done with this.

Comment 33

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/ab9b335bbbc8
https://hg.mozilla.org/releases/mozilla-esr60/rev/5aa4ad6f34d3