Closed
Bug 1491967
Opened 6 years ago
Closed 6 years ago
Resolve build args to objdir paths when possible in Tup
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
When invoking tup with a directory in the srcdir on the command line, we should resolve this to an objdir path when possible and pass it along to the tup invocation. Today we'll just do a partial update based on the srcdir path, not find any tup files, and do nothing. There's a pretty big difference between what tup and make do in case of a partial tree build, so we need to communicate that as well, either as a part of doing this or separately.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9010776 [details] Bug 1491967 - Document the difference between partial tree builds in Make and Tup. Michael Shal [:mshal] has approved the revision.
Attachment #9010776 -
Flags: review+
Comment 4•6 years ago
|
||
Comment on attachment 9009774 [details] Bug 1491967 - Translate arguments to |./mach build| to objdir paths when possible in the tup backend. Michael Shal [:mshal] has approved the revision.
Attachment #9009774 -
Flags: review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f58d9672eee Translate arguments to |./mach build| to objdir paths when possible in the tup backend. r=firefox-build-system-reviewers,mshal https://hg.mozilla.org/integration/autoland/rev/3478b4d04eb9 Document the difference between partial tree builds in Make and Tup. r=mshal
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f58d9672eee https://hg.mozilla.org/mozilla-central/rev/3478b4d04eb9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•