14920 - [4x.P] GFX textfield size="N,M" is treated as size="M"

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Mats Palmgren (inactive)]

GFX textfield size="N,M" is treated as size="M" by apprunner.
Both Navigator 4.08 and IE5 on Windows 98 treats this as size="N".
At the given URL above, it's the textfield in the "Sign up for free newsletter"
form. I'm using apprunner 1999-09-24-09-M11 on Windows 98.
Will attach a testcase to illustrate in a moment.

Comment 1

[Mats Palmgren (inactive)]

Attachment: testcase

Comment 2

[karnaze (gone)]

Reassigning to Kevin.

Comment 3

[Kevin McCluskey (gone)]

I'm not sure this is valid. Do we have to replicate old parsing behavior when
looking at an invalid size specification. I don't think N,M is valid looking at
the HTML4.0 spec.

size = cdata [CN]
     This attribute tells the user agent the initial width of the control. The
width is given in pixels except when type
     attribute has the value "text" or "password". In that case, its value
refers to the (integer) number of characters.

Comment 4

[Kevin McCluskey (gone)]

The problem is the call to nsString::ToInteger returns the second value after
the comma instead of the value before the comma
in nsGenericHTMLElement::ParseValue.

PRBool
nsGenericHTMLElement::ParseValue(const nsString& aString, PRInt32 aMin,
                                 nsHTMLValue& aResult, nsHTMLUnit aValueUnit)
{
  PRInt32 ec, val = aString.ToInteger(&ec);
  if (NS_OK == ec) {
    if (val < aMin) val = aMin;
    if (eHTMLUnit_Pixel == aValueUnit) {
      aResult.SetPixelValue(val);
    }
    else {
      aResult.SetIntValue(val, aValueUnit);
    }
    return PR_TRUE;
  }

  return PR_FALSE;
}

Rick, should nsString::ToString be modified to return the first value instead of
the second in this case of aString.ToInteger("10,40"); ?

Comment 5

[Mats Palmgren (inactive)]

Additional info:
Navigator 3.04, 4.6, 4.61 and IE4 also treats it as size="N"

Comment 6

[rickg]

Fixed by change to GetNumericSubstring(). r=kmcclusk.

Comment 7

[cpratt]

Using the 1999111016 M11 build on NT, this looks the same as in Nav 4.7. Marking
verified.

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/429661361834
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14920 - Show a Tabs Tray CFR Banner for grid view tip (https://github.com/mozilla-mobile/fenix/pull/16466)