get rid of nsIDOMXULLabeledControlElement

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P5
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks 1 bug)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Posted patch patchSplinter Review
depends on bug 1491210
Attachment #9009849 - Flags: review?(bugs)
(Assignee)

Updated

7 months ago
Assignee: nobody → surkov.alexander
Comment on attachment 9009849 [details] [diff] [review]
patch

(I wonder why all this XUL interface removal right now)
Attachment #9009849 - Flags: review?(bugs) → review+

Updated

7 months ago
Priority: -- → P5

Comment 2

7 months ago
I’d recommend submitting patches using Phabricator, as it makes reviewing and landing them easier.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

(Also, Splinter (the subsystem used for reviewing patches submitted directly to BMO) is deprecated)
https://groups.google.com/d/msg/firefox-dev/K4pYO-mtGBY/5UjFKxp7CAAJ
(Phabricator does not make reviewing easier.)
(And I never use sṕlinter on bugzilla. Just the 'details' link.)
(Assignee)

Comment 5

7 months ago
(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #1)
> Comment on attachment 9009849 [details] [diff] [review]
> patch
> 
> (I wonder why all this XUL interface removal right now)

it's part of deXBLization project, where XUL elements either should be reimplemented as custom elements or moved to c++ or removed. Also there's no way currently to make a custom element to implement XUL interface (bug 1478372), thus they are removed when it's possible to ublock/simplify deXBLization.

(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #3)
> (Phabricator does not make reviewing easier.)

I also lean towards to old-style reviews, phabricator feels ok but overcomplicated

Comment 6

7 months ago
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aee03f432203
get rid of nsIDOMXULLabeledControlElement, r=smaug

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aee03f432203
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.