1492051 - Port bug 1491588 - Restore XPCOM registration of nsCommandParams - TEST-UNEXPECTED-FAIL | [snip]/composition/test-image-insertion-dialog.js

Status: RESOLVED FIXED

Description

[Jorg K (GMT+2)]

https://dxr.mozilla.org/comm-central/search?q=embedcomp%2Fcommand-params&redirect=false

Causes test failure:
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1537221390/build/tests/mozmill/composition/test-image-insertion-dialog.js | test-image-insertion-dialog.js::test_image_insertion_dialog_persist

Geoff, can I leave this to you? I have build bustage to worry about.

Comment 1

[Jorg K (GMT+2)]

This is easy:
https://hg.mozilla.org/mozilla-central/rev/2433d39d3abe#l4.12
-          var params = Cc["@mozilla.org/embedcomp/command-params;1"].
-                       createInstance(Ci.nsICommandParams);
+          var params = Cu.createCommandParams();

Comment 2

[Jorg K (GMT+2)]

Attachment: 1492051-createCommandParams.patch

This fixes the test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d2710bb0b4e
Port bug 1491588: replace XPCOM creation of nsICommandParams with Cu.createCommandParams(). rs=bustage-fix

Comment 4

[Jorg K (GMT+2)]

Not my day today :-( - I'm sure I tested this, but now I get:
error thrown in newCommandParams: TypeError: Cu.createCommandParams is not a function
That's also seen in automation.

Comment 5

[Jorg K (GMT+2)]

Very weird:
The Cu.createCommandParams() was added here:
https://hg.mozilla.org/mozilla-central/rev/2433d39d3abe#l3.31

And removed straight away here(???):
https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30

Comment 6

[Jorg K (GMT+2)]

See bug 1491561 comment #6. Looks like an accidental removal. Nothing we can do about it.

Comment 7

[:aceman]

Comment on attachment 9009899 [details] [diff] [review]
1492051-createCommandParams.patch

Review of attachment 9009899 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks