Closed Bug 1492051 Opened 7 years ago Closed 7 years ago

Port bug 1491588 - Restore XPCOM registration of nsCommandParams - TEST-UNEXPECTED-FAIL | [snip]/composition/test-image-insertion-dialog.js

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

https://dxr.mozilla.org/comm-central/search?q=embedcomp%2Fcommand-params&redirect=false Causes test failure: TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1537221390/build/tests/mozmill/composition/test-image-insertion-dialog.js | test-image-insertion-dialog.js::test_image_insertion_dialog_persist Geoff, can I leave this to you? I have build bustage to worry about.
Flags: needinfo?(geoff)
This is easy: https://hg.mozilla.org/mozilla-central/rev/2433d39d3abe#l4.12 - var params = Cc["@mozilla.org/embedcomp/command-params;1"]. - createInstance(Ci.nsICommandParams); + var params = Cu.createCommandParams();
Assignee: nobody → jorgk
Flags: needinfo?(geoff)
This fixes the test.
Attachment #9009899 - Flags: review?(acelists)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/5d2710bb0b4e Port bug 1491588: replace XPCOM creation of nsICommandParams with Cu.createCommandParams(). rs=bustage-fix
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Blocks: 1491588
Not my day today :-( - I'm sure I tested this, but now I get: error thrown in newCommandParams: TypeError: Cu.createCommandParams is not a function That's also seen in automation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Very weird: The Cu.createCommandParams() was added here: https://hg.mozilla.org/mozilla-central/rev/2433d39d3abe#l3.31 And removed straight away here(???): https://hg.mozilla.org/mozilla-central/rev/9bc9a1e07a53#l7.30
See bug 1491561 comment #6. Looks like an accidental removal. Nothing we can do about it.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Comment on attachment 9009899 [details] [diff] [review] 1492051-createCommandParams.patch Review of attachment 9009899 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #9009899 - Flags: review?(acelists) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: