Closed
Bug 1492091
Opened 8 years ago
Closed 8 years ago
Remove a wrong WPT .ini file for subresource-integrity
Categories
(Core :: DOM: Security, enhancement)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
(Whiteboard: [domsecurity-backlog1] [domsecurity-active])
Attachments
(1 file)
|
515 bytes,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
We don't need testing/web-platform/meta/subresource-integrity/idlharness.window.js.ini
| Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
| Assignee | ||
Comment 1•8 years ago
|
||
Attachment #9009898 -
Flags: review?(ckerschb)
Comment 2•8 years ago
|
||
(In reply to Andrea Marchesini [:baku] from comment #0)
> We don't need
> testing/web-platform/meta/subresource-integrity/idlharness.window.js.ini
How come that's not causing any problems on TRY at the moment? I mean how come we can remove that file without any actual code updates?
Flags: needinfo?(amarchesini)
| Assignee | ||
Comment 3•8 years ago
|
||
Because that test doesn't exist. If you add in any .ini file [something that doesn't exist], this is ignored.
Flags: needinfo?(amarchesini)
Comment 4•8 years ago
|
||
Comment on attachment 9009898 [details] [diff] [review]
subresource.patch
Review of attachment 9009898 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Andrea Marchesini [:baku] from comment #3)
> Because that test doesn't exist. If you add in any .ini file [something that
> doesn't exist], this is ignored.
Ah, the test itself doesn't even exist. How did you figure that?
Attachment #9009898 -
Flags: review?(ckerschb) → review+
| Assignee | ||
Comment 5•8 years ago
|
||
> Ah, the test itself doesn't even exist. How did you figure that?
Running them locally and controlling that the result was 6/6 (or something similar).
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16265d1e65ee
Remove a wrong WPT .ini file for subresource-integrity, r=ckerschb
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•