1492095 - Replace the XPCOM component registration for nsAppStartupNotifier removed in bug 1491741

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Causes test failures:
TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:comm/calendar/test/unit/test_alarmservice.js | - TypeError: Components.classes['@mozilla.org/embedcomp/appstartup-notifier;1'] is undefined;

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1492095-nsAppStartupNotifier.patch - not working, backed out.

Same recipe as before.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b656dcc776f9
Replace the XPCOM component registration for nsAppStartupNotifier removed in bug 1491741. rs=bustage-fix DONTBUILD

Comment 3

[Jorg K (CEST = GMT+2)]

This compiled locally, but now I see that Linux and Mac are busted:
/builds/worker/workspace/build/src/comm/common/src/nsCommonModule.cpp:23:1: error: no member named 'QueryInterface' in 'nsAppStartupNotifier'
/builds/worker/workspace/build/src/obj-thunderbird/dist/include/mozilla/RefPtr.h:47:11: error: no member named 'Release' in 'nsAppStartupNotifier'
/builds/worker/workspace/build/src/obj-thunderbird/dist/include/mozilla/RefPtr.h:44:11: error: no member named 'AddRef' in 'nsAppStartupNotifier'

I noticed that Ehsan took this line away:
https://hg.mozilla.org/mozilla-central/rev/f60256376b97#l2.19

Or maybe it's due to the DeCOMtamination here:
https://hg.mozilla.org/mozilla-central/rev/a31e6269caee

In that case the recipe doesn't work and we need to take the approach of
https://hg.mozilla.org/comm-central/rev/a8bd1c32fd2d

Comment 4

[Jorg K (CEST = GMT+2)]

Grrr, I forgot to pull the latest M-C :-(

Comment 5

[Jorg K (CEST = GMT+2)]

Looking at this further, I think we're out of luck here. The approach of bug 1485275 (https://hg.mozilla.org/comm-central/rev/a8bd1c32fd2d), because the nsAppStartupNotifier lost its XPCOM interface altogether.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1492095-remove-use-of-nsAppStartupNotifier.patch

Here's a bustage fix. Tests pass with the usage of "@mozilla.org/embedcomp/appstartup-notifier;1" simply removed.

Comment 7

[Jorg K (CEST = GMT+2)]

Over to you, Geoff.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cfc817da7111
Backed out changeset b656dcc776f9 for causing bustage. a=backout
https://hg.mozilla.org/comm-central/rev/96176520c895
temporarily remove use of nsAppStartupNotifier after removal of its XPCOM interface in bug 1491741. rs=bustage-fix DONTBUILD

Comment 9

[Geoff Lankow (:darktrojan)]

Philipp, is there a reason we use the app startup notifier instead of the observer service here? Can I just replace the use of one with the other?

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: 1492095-startup-notifier-1.diff

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9011337 [details] [diff] [review]
1492095-startup-notifier-1.diff

Review of attachment 9011337 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with eslint checked.

::: calendar/base/src/calAlarmService.js
@@ +227,5 @@
>          Services.obs.addObserver(this, "xpcom-shutdown");
>          Services.obs.addObserver(this, "wake_notification");
>  
> +        // Make sure the alarm monitor is alive so it's observing the notification.
> +        Cc["@mozilla.org/calendar/alarm-monitor;1"].getService(Ci.calIAlarmServiceObserver);

Does this pass eslint? You may need to disable no-unused-expressions in a comment for this to pass.

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: 1492095-startup-notifier-2.diff

That passes, but my notifyObserver calls don't.

Comment 13

[Geoff Lankow (:darktrojan)]

Checkin needed with a backout of 96176520c895.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6dfdc289650b
Backed out temporary fix from changeset 96176520c895. a=backout
https://hg.mozilla.org/comm-central/rev/8b20130d8bb9
Replace use of XPCOM 'embedcomp/appstartup-notifier' after its removal in bug 1491741. r=philipp