Closed Bug 1492128 Opened Last year Closed Last year

Send email when release build started

Categories

(Release Engineering :: Release Automation: Other, enhancement, P3)

enhancement

Tracking

(firefox-esr60 fixed, firefox64 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: rail, Assigned: tomprince)

References

Details

(Whiteboard: [releaseduty])

Attachments

(13 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
After switching to ship-it v2, we stopped sending the "build started" emails - no more releaserunner \o/. Some people requested this back, because it's useful.

It should be easy to add this as a separate task.
Whiteboard: [releaseduty]
Just sending the email is something similar to release-notify-promote or so, with minor adjustements. 

For posterity whenever we'll tackle the buglist for QA as well:

jcristau> fwiw the bit QA is most interested in having back is the bug list from the old ship-it emails
16:13:20 <~mtabara> re: the bug list, that can be done too. we can move the logic from release runner  to in-tree task or something
16:17:35 <~mtabara> we have it in tools here - https://hg.mozilla.org/build/tools/file/tip/lib/python/kickoff/__init__.py#l88 and it's processed here https://hg.mozilla.org/build/tools/file/tip/lib/python/kickoff/buglist_creator.py
16:17:59 <~mtabara> not sure what/if any credentials are used, but if they are not, we could move that logic to in-tree
16:18:20 <~mtabara> that'd be even better actually but as rail said, not trivial at first glance
Long-term solution here is to have:
* the TC notify task in order to announce the release has started
* have this run on the docker-worker so that it also runs a script
* move logic from tools repo in the docker worker and the results be pasted in the artifacts or somewhere where it can be read
* ideally the ULR of the artifacts or w\e consists the subject of the message
* we'd need a bugzilla account + secrets to access the API to grab the information we need 

Back-up solution(s) for this:
a) provide QE a way to run this command to get the bug diff
b) releaseduty to run this for QE
Priority: -- → P3
We may want a "`release_promotion_flavor` started" email for each graph. For instance, if we have a `The Firefox 64.0b3 ship graph has been scheduled` email, that would alert people that it's scheduled, even if it won't run til after the promote or push graphs. It would also help us know if we accidentally hit `ship` when we didn't mean to.

(This might be a separate bug; a single email with bug info at the start of the promote phase would probably solve comment 0.)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
For tasks that only need python, the base images are sufficient. The in-tree
code verifies that the caches are setup as volumes in the image being used,
so set the caches in the base images as well.
Attachment #9021015 - Attachment description: Bug 1492128: Vendor taskcluster; r?build → Bug 1492128: Vendor taskcluster==4.0.1; r?build
Attachment #9021014 - Attachment description: Bug 1492128: Vendor pathlib2; r?build → Bug 1492128: Vendor pathlib2==2.3.2; r?build
Attachment #9021019 - Attachment description: Bug 1492128: Set TASKCLUSTER_ROOT_URL in tasks that use the taskcluster proxy; r?dustin → Bug 1492128: Set TASKCLUSTER_BASE_URL in tasks that use the taskcluster proxy; r?dustin
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/1319783f4809
Vendor pathlib2==2.3.2; r=firefox-build-system-reviewers,gps
https://hg.mozilla.org/integration/autoland/rev/b314c0a4d03f
Vendor taskcluster==4.0.1; r=firefox-build-system-reviewers,gps
https://hg.mozilla.org/integration/autoland/rev/2d15a1d91cb2
[mozrelease] Add mozrelease tests to taskcluster; r=mtabara
Attachment #9021019 - Attachment description: Bug 1492128: Set TASKCLUSTER_BASE_URL in tasks that use the taskcluster proxy; r?dustin → Bug 1492128: Set TASKCLUSTER_ROOT_URL in tasks that use the taskcluster proxy; r?dustin
Keywords: leave-open
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/778d969a1dab
Add `VOLUME` definitions to base debian images; r=gps
https://hg.mozilla.org/integration/autoland/rev/31237fb789a2
Set TASKCLUSTER_ROOT_URL in tasks that use the taskcluster proxy; r=dustin
https://hg.mozilla.org/integration/autoland/rev/bca63676be6e
[mozrelease] Import buglist_creator from build-tools; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/d7a7068b519f
[mozrelease] Add buglist_creator to test-suite; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/c9194dc8a470
[mozrelease] Fix flake8 errors in buglist_creator; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/8f2c67323ea3
[mozrelease] Cleanup buglist_creator code; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/5a4d509ac7a5
[mozrelease] Add command to generate buglist for a given release; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/5e9ec632aff4
[mozrelease] Send an email when a release starts with a bug list; r=mtabara
https://hg.mozilla.org/integration/autoland/rev/b67bb5ef663e
[mozrelease] Pass repository to buglist commands; r=mtabara
@tom: are we uplifting this stuff to beta to immediate benefit or do should we let this ride the train?
Again, great great job with this.
Flags: needinfo?(mozilla)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/005931f03bee
[mozrelease] Fix typo in taskcluster proxy configuration; r=me
Flags: needinfo?(mozilla)
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Hello! If possible would it be too much of a hassle to change the shortURL for bugzilla queries to something more like a hyperlink with the full url? 
We have restrictions here (in the Softvision office) with shorturls, and have problems opening links like https://mzl.la/, bit.ly and others. If it’s too much to ask that's fine, we can always use some online “expand url” tools.

Other then that, it's good to see this email back in action \o/
Flags: needinfo?(mozilla)
(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #24)
> Hello! If possible would it be too much of a hassle to change the shortURL
> for bugzilla queries to something more like a hyperlink with the full url? 

Sure. Now that the code is in tree, it is easy to iterate on. Feel free to file other bugs for other improvements.
Flags: needinfo?(mozilla)
:bogdan_maris I've sent you a sample email generated with the updated code from the above patch. If that looks good, and the code gets review, we should be able to land it for the next beta.
(In reply to Tom Prince [:tomprince] from comment #27)
> :bogdan_maris I've sent you a sample email generated with the updated code
> from the above patch. If that looks good, and the code gets review, we
> should be able to land it for the next beta.

Thanks very much, it looks brilliant from our point of view!
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/7ec7580e43e4
[mozrelease] Tweak buglist email to be nicely formated and not use URL shortener; r=mtabara
I noticed we didn't get an email when Firefox 60.4.0 build2 started, is this easily upliftable to esr60 ?
You need to log in before you can comment on or make changes to this bug.