1492154 - Session service does not handle custom protocols properly

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[JustOff]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20100101

Steps to reproduce:

1. Set up the browser to restore previous session on startup
2. Install Classic Add-ons Archive (CAA) add-on from https://github.com/JustOff/ca-archive/releases/download/1.1.4/ca-archive-1.1.5b1.xpi
3. Click the CAA button to open the catalog (or type "caa:" in the urlbar)
4. Restart the browser


Actual results:

1. The console displays an error at https://dxr.mozilla.org/comm-esr52/source/suite/common/src/nsSessionStore.js#1696 when you explore CAA.
2. The tab with CAA does not restored after the browser restart.



Expected results:

All tabs must be restored and errors should not occur.

Comment 1

[JustOff]

I think this can be easily fixed by replacing

  let origin = principal.origin;

with

  let origin;
  try {
    origin = principal.origin;
  }
  catch (ex) {
    origin = principal.URI.spec;
  }

at https://dxr.mozilla.org/comm-esr52/source/suite/common/src/nsSessionStore.js#1696

PS: I would also like to draw your attention that the condition at https://dxr.mozilla.org/comm-esr52/source/suite/common/src/nsSessionStore.js#1700 will never be fulfilled, as the principal does not contain either uri or url.

Comment 2

[Frank-Rainer Grahl (:frg)]

> origin = principal.origin;

You sure the assignnemt throws and not just returns null in which case and if (!... might be better?

> as the principal does not contain either uri or url.
Hmm this looks like a typo. Should be URI I think. 6 years old. Must not be important :)

I look at it when I find some time. Maybe this weekend.

Comment 3

[JustOff]

> You sure the assignment throws and not just returns null?

NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPrincipal.origin]

> I look at it when I find some time.

Thank you.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1492154-sessionstore-249.patch

Changes seem to not cause a regression but I didin't try the build yet much.

I will send the patch to Bill for putting into his unoffical builds:

http://www.wg9s.com/comm-esr/

Please check if it fixes you regression when the build is up. Patch should appear in this directory then:
http://www.wg9s.com/comm-esr/patches/git/comm-esr52/

Porting to 2.53+ now.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1492154-sessionstore-249.patch

just the comment changed.

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1492154-sessionstore.patch

Patch for 2.53 and 2.57

Comment 7

[JustOff]

Thank you, I confirm the regression is fixed in WG9s SeaMonkey 2.49.5 build 20180923041539.

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9011276 [details] [diff] [review]
1492154-sessionstore.patch

Into all trees for the Good of SeaMonkeykind

Comment 9

[Ian Neal]

Comment on attachment 9011276 [details] [diff] [review]
1492154-sessionstore.patch

Wonder how those typos slipped through
LGTM r/a=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb81266621e3
Allow for invalid origin in principal and fix misspelled principal uri and url in sessionstore. r=IanN

Comment 11

[Frank-Rainer Grahl (:frg)]

 https://hg.mozilla.org/releases/comm-esr60/rev/307328b798db41e6d2f7258e0db0909baec969f6

Comment 12

[Frank-Rainer Grahl (:frg)]

Target 2.49.5
https://hg.mozilla.org/releases/comm-esr52/rev/883ee2aed9c0f0e50bd3530c984e3631cd3c858a