Closed Bug 1492186 Opened 6 years ago Closed 6 years ago

Intermittent browser/base/content/test/pageinfo/browser_pageinfo_images.js | Number of images listed: X, should be Y -

Categories

(Firefox :: Page Info Window, defect, P5)

Product:
Firefox
Component:
Page Info Window
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1492186 - make browser_pageinfo_images.js more reliable, r?florian
46 bytes, text/x-phabricator-request
florian
: review+
Details | Review 
Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=199943234&repo=autoland

https://queue.taskcluster.net/v1/task/Ygn1-MojQGmbzyevayQk4Q/runs/0/artifacts/public/logs/live_backing.log

[task 2018-09-18T13:27:43.867Z] 13:27:43     INFO - TEST-START | browser/base/content/test/pageinfo/browser_pageinfo_images.js
[task 2018-09-18T13:27:44.251Z] 13:27:44     INFO - TEST-INFO | started process screentopng
[task 2018-09-18T13:27:44.775Z] 13:27:44     INFO - TEST-INFO | screentopng: exit 0
[task 2018-09-18T13:27:44.775Z] 13:27:44     INFO - Buffered messages logged at 13:27:44
[task 2018-09-18T13:27:44.777Z] 13:27:44     INFO - Console message: Security Error: Content at moz-nullprincipal:{011f6e5a-ec97-4fe2-af46-513acf2e406d} may not load or link to file:///dummy_image.gif.
[task 2018-09-18T13:27:44.778Z] 13:27:44     INFO - Console message: Security Error: Content at moz-nullprincipal:{011f6e5a-ec97-4fe2-af46-513acf2e406d} may not load or link to file:///dummy_icon.ico.
[task 2018-09-18T13:27:44.780Z] 13:27:44     INFO - Console message: [JavaScript Error: "NS_ERROR_DOM_BAD_URI: Component returned failure code: 0x805303f4 [nsIChannel.asyncOpen2]"]
[task 2018-09-18T13:27:44.781Z] 13:27:44     INFO - load@resource:///modules/FaviconLoader.jsm:102:7
[task 2018-09-18T13:27:44.782Z] 13:27:44     INFO - load@resource:///modules/FaviconLoader.jsm:397:43
[task 2018-09-18T13:27:44.784Z] 13:27:44     INFO - async*loadIcons@resource:///modules/FaviconLoader.jsm:454:7
[task 2018-09-18T13:27:44.785Z] 13:27:44     INFO - onPageShow@resource:///modules/FaviconLoader.jsm:486:7
[task 2018-09-18T13:27:44.786Z] 13:27:44     INFO - onHeadParsed@resource:///actors/LinkHandlerChild.jsm:55:7
[task 2018-09-18T13:27:44.787Z] 13:27:44     INFO - handleEvent@resource:///actors/LinkHandlerChild.jsm:160:16
[task 2018-09-18T13:27:44.788Z] 13:27:44     INFO - handleActorEvent@resource://gre/modules/ActorManagerChild.jsm:83:33
[task 2018-09-18T13:27:44.789Z] 13:27:44     INFO - EventListener.handleEvent*addEventListener@resource://gre/modules/ActorManagerChild.jsm:59:5
[task 2018-09-18T13:27:44.790Z] 13:27:44     INFO - init@resource://gre/modules/ActorManagerChild.jsm:46:7
[task 2018-09-18T13:27:44.791Z] 13:27:44     INFO - attach@resource://gre/modules/ActorManagerChild.jsm:229:48
[task 2018-09-18T13:27:44.792Z] 13:27:44     INFO - @chrome://global/content/browser-content.js:14:1
[task 2018-09-18T13:27:44.794Z] 13:27:44     INFO - 
[task 2018-09-18T13:27:44.795Z] 13:27:44     INFO - Console message: Security Error: Content at moz-nullprincipal:{011f6e5a-ec97-4fe2-af46-513acf2e406d} may not load or link to file:///dummy_icon.ico.
[task 2018-09-18T13:27:44.796Z] 13:27:44     INFO - TEST-PASS | browser/base/content/test/pageinfo/browser_pageinfo_images.js | Image tree is null (media tab is broken) - 
[task 2018-09-18T13:27:44.798Z] 13:27:44     INFO - Buffered messages finished
[task 2018-09-18T13:27:44.800Z] 13:27:44     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/pageinfo/browser_pageinfo_images.js | Number of images listed: 2, should be 7 - 
[task 2018-09-18T13:27:44.801Z] 13:27:44     INFO - Stack trace:
[task 2018-09-18T13:27:44.802Z] 13:27:44     INFO - chrome://mochitests/content/browser/browser/base/content/test/pageinfo/browser_pageinfo_images.js:test/</</</<:20
[task 2018-09-18T13:27:44.803Z] 13:27:44     INFO - chrome://mochikit/content/browser-test.js:run:1333
[task 2018-09-18T13:27:44.804Z] 13:27:44     INFO - Console message: Security Error: Content at moz-nullprincipal:{011f6e5a-ec97-4fe2-af46-513acf2e406d} may not load or link to file:///dummy_object.svg.
[task 2018-09-18T13:27:44.806Z] 13:27:44     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<html>  <head>    <title>Test for media tab</title>    <link rel='shortcut icon' href='file:///dummy_icon.ico'>  </head>  <body style='background-image:url(about:logo?a);'>    <img src='file:///dummy_image.gif'>    <ul>      <li style='list-style:url(about:logo?b);'>List Item 1</li>    </ul>      <div style='-moz-border-image: url(about:logo?c) 20 20 20 20;'>test</div>    <a href='' style='cursor: url(about:logo?d),default;'>test link</a>    <object type='image/svg+xml' width=20 height=20 dat" line: 0}]
[task 2018-09-18T13:27:44.807Z] 13:27:44     INFO - Console message: Security Error: Content at moz-nullprincipal:{011f6e5a-ec97-4fe2-af46-513acf2e406d} may not load or link to file:///dummy_image.gif.
[task 2018-09-18T13:27:44.807Z] 13:27:44     INFO - GECKO(1945) | MEMORY STAT | vsize 1737MB | residentFast 311MB | heapAllocated 127MB
[task 2018-09-18T13:27:44.808Z] 13:27:44     INFO - TEST-OK | browser/base/content/test/pageinfo/browser_pageinfo_images.js | took 485ms
[task 2018-09-18T13:27:44.810Z] 13:27:44     INFO - checking window state
The pushes before that have that failure in a different chunk (bc2). Will add retriggers and backfills for that one.
This must be some bizarre race condition - the test looks pretty old-school. I can't reproduce on my local mac, not even with --verify. I'll keep looking, I guess, but my changes shouldn't have changed anything about the page info window's image/media tab - I imagine it's a side effect of one of the previous tests being removed.
Retriggers for previous pushes don't fail - it's really from bug 1491243.
Hopefully this helps:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3081921a9184f9aca1fb593f634f6574ff60b34

I'll need to retrigger the right chunk once it's run to check it worked.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs (he/him) from comment #6)
> Hopefully this helps:
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d3081921a9184f9aca1fb593f634f6574ff60b34
> 
> I'll need to retrigger the right chunk once it's run to check it worked.

D'oh, forgot to hg add:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=265744058a387f3794941f40ceb4a894bc5aab9b
Summary: Intermittent browser/base/content/test/pageinfo/browser_pageinfo_images.js | Number of images listed: 2, should be 7 - → Intermittent browser/base/content/test/pageinfo/browser_pageinfo_images.js | Number of images listed: X, should be Y -
Comment on attachment 9010434 [details]
Bug 1492186 - make browser_pageinfo_images.js more reliable, r?florian

Florian Quèze [:florian] has approved the revision.
Attachment #9010434 - Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5a6cfbdc31fd
make browser_pageinfo_images.js more reliable, r=florian
https://hg.mozilla.org/mozilla-central/rev/5a6cfbdc31fd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: