1492220 - Tab crashes when visiting v-fonts

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect, P1)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: DevTools Font Editor with weird characters

Visiting v-fonts.com with the latest Nightly on OS X 10.13.6 crashes the tab.

Here is my crash report: https://crash-stats.mozilla.com/report/index/e9306b6b-01c1-4415-93f0-0c7fd0180918

Not sure if it's related, but axis names of variable fonts started to render with a special character in the devtools (see screenshot).

Comment 1

[Jonathan Kew [:jfkthame]]

Ugh, this may well be a regression from bug 1490402 or one of the other recent changes to how we handle font-related names. Will try to investigate...

Comment 2

[Marcia Knous [:marcia]]

I also hit a crash on this site a while back and filed bug 1491030, but I did get a different signature.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Fix encoding-form mismatch in macOS impl of GetVariationAxes

Yep, definitely a regression from bug 1490402, mixing utf-16 and utf-8 strings incorrectly. In most cases the compiler would have flagged such a mismatch, but the explicit cast here (because the macOS APIs use their own UniChar type) defeated that and meant this one slipped through.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db71467a0b8
Fix encoding-form mismatch in macOS impl of GetVariationAxes. r=lsalzman

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2db71467a0b8

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the crashes on MacOS 10.13.6 and MacOs 10.14 using Nightly build from 2018-09-18.
Verified as fixed on MacOS 10.13, macOS 10.14, macOS 10.11 with 64.0b4 build.