1492273 - Convert selectedJob to a Context

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[Cameron Dawson [:camd]]

Effort level 4.

Realized we needed this when converting away from the Angular event model and the ThResultSetStore.

Comment 1

[Cameron Dawson [:camd]]

Attachment: GitHub Pull Request

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 9010378 [details] [review]
GitHub Pull Request

The PR this depends on was reverted and reopened; waiting until that's resolved before reviewing since it will presumably mean changes here (there are already conflicts).

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/27d4db65686173b87102af92d8c51b75cd4d472a
Bug 1492273 - Use a Context to manage selectedJob

This will allow us to use the SelectedJob context coming in the next commit.
These changes are tangled with that next commit, but I hoped this would
make it easier to review by removing this noise.

Comment 4

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder/pull/4041/files#r219617686

Comment 5

[Cameron Dawson [:camd]]

This param can be removed.  It doesn't need it.  Created PR https://github.com/mozilla/treeherder/pull/4062

Comment 6

[Cameron Dawson [:camd]]

Attachment: GitHub Pull Request