Only fetch target task for actions that require it
Categories
(Firefox Build System :: Task Configuration, task, P5)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: dustin, Assigned: ialokkumarsingh0, Mentored)
Details
Attachments
(1 file)
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Dustin, can you assign me?
Assignee | ||
Comment 3•6 years ago
|
||
Dustin, I didn't find any taskgraph file in taskcluster how I can get started with this issue?
Reporter | ||
Comment 4•6 years ago
|
||
This bug is in the Firefox source code (https://hg.mozilla.org/mozilla-central/). You can find more information at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code.
I'd suggest getting a checkout of that repository set up, but you don't need to go so far as building Firefox (you can if you want, though!). In the checkout, run ./mach taskgraph tasks
. That runs the task-generation system that is how we determine what tasks to run for each push. https://firefox-source-docs.mozilla.org/taskcluster/taskcluster/taskgraph.html has more information. Once that's working, you've got everything set up to get started.
Next, have a look at the code in taskcluster/taskgraph/actions. It sets up a kind of registry, and registers a bunch of actions. All of them get a task
argument, but not all of them use it. The snippet of code in the first comment of this bug takes the time to fetch the task for each one, though. So, please refactor so that only the actions that need that data fetch it.
Finally, to submit the patch, you'll need to set up a Phabricator account -- docs are at https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#user-guide
Most of this set-up is one-time work that will be useful to you in working on other Firefox bugs -- and there are plenty of them to work on! So consider it a worthwhile investment of time.
Assignee | ||
Comment 5•6 years ago
|
||
Dustin, I successfully clone the mozilla/central repo from mercurial and run the command ./mach taskgraph tasks
all things work as expected. I saw the taskcluster/taskgraph/actions/ folder there is a bunch of files which contains callback and this callback trigger from register.py since we are fetching task-definition from taskid for every task but every task does not need this. I understand the problem(if not please suggest me if I am missing something) but one simple question How do I know which callback need this or which not? And How I can test the change I made(is it working right or not)?
Reporter | ||
Comment 6•6 years ago
|
||
You can tell the callbacks that don't need this information because they never reference the task
variable. Testing will be a bit tricky, especially without the permissions to run some of these actions, but I can take care of that.
Assignee | ||
Comment 7•6 years ago
|
||
Reporter | ||
Comment 8•6 years ago
|
||
Comment 10•6 years ago
|
||
bugherder |
Description
•