Closed
Bug 1492301
Opened 6 years ago
Closed 6 years ago
Remove Debugger.allowWasmBinarySource
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(1 file)
|
27.21 KB,
patch
|
yury
:
review+
|
Details | Diff | Splinter Review |
Sounds like it's always true nowadays.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9024883 [details] [diff] [review] rm-allow-binary-source Review of attachment 9024883 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. (No sure about change in the js/src/builtin/TestingFunctions.cpp) ::: js/src/builtin/TestingFunctions.cpp @@ -662,5 @@ > static bool > WasmThreadsSupported(JSContext* cx, unsigned argc, Value* vp) > { > CallArgs args = CallArgsFromVp(argc, vp); > -#ifdef ENABLE_WASM_THREAD_OPS This change is not related to the bug
Attachment #9024883 -
Flags: review?(ydelendik) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Oops, right, that hunk was from bug 1504288.
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/52fea45d5342 Baldr: remove unneeded Debugger.allowWasmBinarySource option (r=yury)
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52fea45d5342
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•