browser.xhtml: focus is wrong in various tests

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: bdahl, Assigned: bdahl)

Tracking

unspecified
Firefox 64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
browser_popupNotification_keyboard.js was failing with browser.xhtml

This was caused by document.activeElement behaving differently in XUL and HTML. We should roll back the changes in bug 1485157 and fix activeElement.
If we were able to create a <head>/<body> element for browser.xhtml would that allow us to skip the nsDocument change there? Or is it important that we return the documentElement instead of the body anyway?
Status: NEW → ASSIGNED
(Assignee)

Comment 3

7 months ago
(In reply to Brian Grinstead [:bgrins] from comment #2)
> If we were able to create a <head>/<body> element for browser.xhtml would
> that allow us to skip the nsDocument change there? Or is it important that
> we return the documentElement instead of the body anyway?

I'm unsure, will need to do some testing.
See Also: → 1492582
(Assignee)

Comment 4

7 months ago
Return the document element as the activeElement when there is no body
element, the document is chrome privileged, and the document element
is a XUL element.

MozReview-Commit-ID: JFDLAqOmLTS
Comment on attachment 9010809 [details]
Bug 1492327 - Mimic XUL activeElement behavior for XUL in XHTML. r=gijs

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9010809 - Flags: review+

Comment 6

7 months ago
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fee2deb0567
Mimic XUL activeElement behavior for XUL in XHTML. r=smaug

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7fee2deb0567
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
(Assignee)

Updated

6 months ago
See Also: → 1502523
You need to log in before you can comment on or make changes to this bug.