Closed Bug 1492327 Opened 6 years ago Closed 6 years ago

browser.xhtml: focus is wrong in various tests

Categories

(Firefox :: General, enhancement, P3)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file)

Bug 1492327 - Mimic XUL activeElement behavior for XUL in XHTML. r=gijs
46 bytes, text/x-phabricator-request
smaug
: review+
Details | Review 
browser_popupNotification_keyboard.js was failing with browser.xhtml

This was caused by document.activeElement behaving differently in XUL and HTML. We should roll back the changes in bug 1485157 and fix activeElement.
If we were able to create a <head>/<body> element for browser.xhtml would that allow us to skip the nsDocument change there? Or is it important that we return the documentElement instead of the body anyway?
Status: NEW → ASSIGNED
(In reply to Brian Grinstead [:bgrins] from comment #2)
> If we were able to create a <head>/<body> element for browser.xhtml would
> that allow us to skip the nsDocument change there? Or is it important that
> we return the documentElement instead of the body anyway?

I'm unsure, will need to do some testing.
See Also: → 1492582
Return the document element as the activeElement when there is no body
element, the document is chrome privileged, and the document element
is a XUL element.

MozReview-Commit-ID: JFDLAqOmLTS
Comment on attachment 9010809 [details]
Bug 1492327 - Mimic XUL activeElement behavior for XUL in XHTML. r=gijs

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9010809 - Flags: review+
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fee2deb0567
Mimic XUL activeElement behavior for XUL in XHTML. r=smaug
https://hg.mozilla.org/mozilla-central/rev/7fee2deb0567
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
See Also: → 1502523
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: